Re: allow a differn't diff.context config for git format-patch

[Jeff King <peff@peff.net>]

On Tue, May 14, 2019 at 05:54:46AM -0400, Jeff King wrote:

> On Sun, May 12, 2019 at 07:29:42AM -0500, Shawn Landden wrote:
> 
> > > After init_revisions(), we'll have called diff_setup(), which puts
> > > diff_context_default into revs->diffopt. So we still have to do the "if
> > > we have a format-specific value, then override..." conditional. But we
> > > can do it without touching the hidden variable:
> > >
> > Looks like this fell into the cracks. You guys know the code much better
> > than me, but do I have to write a patch to make this happen?
> 
> I think there is more work to be done in actually parsing such a config
> option, plus adding documentation and tests.
> 
> But more importantly, it needs somebody to champion the feature. I don't
> find it an unreasonable thing to want. But I'm not personally
> interested, nor am I completely sure that it wouldn't have any unwanted
> side effects.
> 
> So ideally somebody would write the patch and a compelling commit
> message that explains why it is a good idea.

By the way, if you (or anybody) is interested, looking at how signoff is
implemented (try "git grep -i format.signoff") should get you most of
the way there.

-Peff