From: Jeff King <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Alyssa Ross <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH] doc: explain why file: URLs and bundles don't mix Date: Tue, 14 May 2019 05:29:01 -0400 [thread overview] Message-ID: <20190514092900.GA11679@sigill.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Mon, May 13, 2019 at 05:05:14PM +0900, Junio C Hamano wrote: > I think what is closer to the reaility is that we check if the > source is a bundle when the local filesystem path is used and try to > clone from the bundle, before using the local filesystem path as a > directory we can "clone --local" from. On the other hand, when the > <scheme>://<path> syntax is used, we do not even bother seeing if > the named resource is a bundle, or if --local optimization is > possible (because we do not bother seeing if the named resource is a > local filesystem entity, either). Yeah. My concern on reading Alyssa's patch is that it goes into too much detail about "why", when this is basically just "it's a bug that nobody has yet fixed". I think it makes sense to warn people about the behavior, but we should probably be vague about the reasons and up-front that there is really no good reason that it doesn't work (and it might in the future). Of course fixing the issue is better still. ;) > A possibly interesting tangent to think about is what would happen > if we slightly tweak the above design. What it would require for > the code to take "git clone https://site/repo.bndl", realize that > the named resource is a bundle file, curl/wget it and clone from > that downloaded bundle? And if it is feasible to implement, would > it even be a good idea to begin with? I do not have a ready answer > to either of these questions myself. I've been meaning to come back to this for, oh, going on 8 years now: https://public-inbox.org/git/20111110074330.GA27925@sigill.intra.peff.net/ (though it was meant to work with a CDN "try this first then top-off" strategy; with Jonathan Tan's more flexible CDN work which uses raw packfiles, I doubt I'd come back to this). -Peff
prev parent reply other threads:[~2019-05-14 9:29 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-13 0:23 Alyssa Ross 2019-05-13 8:05 ` Junio C Hamano 2019-05-13 16:54 ` Alyssa Ross 2019-05-14 9:30 ` Jeff King 2019-05-14 9:29 ` Jeff King [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190514092900.GA11679@sigill.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] doc: explain why file: URLs and bundles don'\''t mix' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).