From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: new segfault in master (6a6c0f10a70a6eb1)
Date: Sat, 11 May 2019 20:57:11 +0000 [thread overview]
Message-ID: <20190511205711.tdclwrdixaau75zv@dcvr> (raw)
This test-tool submodule segfault seems new. Noticed it while
checking dmesg for other things.
There's also "name-rev HEAD~4000" (bottom), which is old, I think...
Core was generated by `$WT/t/helper/test-tool submodule-nested-repo-config submodule sub'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x0000559b12746174 in get_oid_with_context_1 (
repo=repo@entry=0x7ffc5de3cf30,
name=name@entry=0x559b1280a882 ":.gitmodules", flags=flags@entry=0,
prefix=prefix@entry=0x0, oid=oid@entry=0x7ffc5de3ce80,
oc=oc@entry=0x7ffc5de3ce20) at sha1-name.c:1840
1840 if (!repo->index->cache)
(gdb) #0 0x0000559b12746174 in get_oid_with_context_1 (
repo=repo@entry=0x7ffc5de3cf30,
name=name@entry=0x559b1280a882 ":.gitmodules", flags=flags@entry=0,
prefix=prefix@entry=0x0, oid=oid@entry=0x7ffc5de3ce80,
oc=oc@entry=0x7ffc5de3ce20) at sha1-name.c:1840
#1 0x0000559b12746dc3 in get_oid_with_context (oc=0x7ffc5de3ce20,
oid=0x7ffc5de3ce80, flags=0, str=str@entry=0x559b1280a882 ":.gitmodules",
repo=repo@entry=0x7ffc5de3cf30) at sha1-name.c:1946
#2 repo_get_oid (r=r@entry=0x7ffc5de3cf30,
name=name@entry=0x559b1280a882 ":.gitmodules",
oid=oid@entry=0x7ffc5de3ce80) at sha1-name.c:1595
#3 0x0000559b12753447 in config_from_gitmodules (
fn=fn@entry=0x559b127534b0 <config_print_callback>,
repo=repo@entry=0x7ffc5de3cf30, data=0x559b145802c0)
at submodule-config.c:633
#4 0x0000559b12754664 in print_config_from_gitmodules (
repo=repo@entry=0x7ffc5de3cf30, key=<optimized out>)
at submodule-config.c:742
#5 0x0000559b126dca4f in cmd__submodule_nested_repo_config (
argc=<optimized out>, argv=0x7ffc5de3d290)
at t/helper/test-submodule-nested-repo-config.c:27
#6 0x0000559b126d367f in cmd_main (argc=3, argv=0x7ffc5de3d290)
at t/helper/test-tool.c:109
#7 0x0000559b126d337a in main (argc=4, argv=0x7ffc5de3d288)
at common-main.c:50
(gdb) quit
Looks like a stack overflow:
Core was generated by `$WT/git name-rev HEAD~4000'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007f4df1896d6a in _int_malloc (
av=av@entry=0x7f4df1bb7b00 <main_arena>, bytes=bytes@entry=33)
at malloc.c:3444
(gdb) #0 0x00007f4df1896d6a in _int_malloc (
av=av@entry=0x7f4df1bb7b00 <main_arena>, bytes=bytes@entry=33)
at malloc.c:3444
#1 0x00007f4df1897b68 in malloc_check (sz=32, caller=<optimized out>)
at hooks.c:295
#2 0x00005642d1240f51 in do_xmalloc (size=size@entry=32,
gentle=gentle@entry=0) at wrapper.c:60
#3 0x00005642d12410e7 in xmalloc (size=size@entry=32) at wrapper.c:87
#4 0x00005642d10c75b1 in name_rev (commit=0x5642d2357bb0,
tip_name=tip_name@entry=0x5642d245e7c0 "master",
taggerdate=taggerdate@entry=1000799900, generation=generation@entry=1044,
distance=distance@entry=1044, from_tag=from_tag@entry=0, deref=0)
at builtin/name-rev.c:103
#5 0x00005642d10c74e3 in name_rev (commit=<optimized out>,
tip_name=tip_name@entry=0x5642d245e7c0 "master",
taggerdate=taggerdate@entry=1000799900, generation=generation@entry=1043,
distance=distance@entry=1043, from_tag=from_tag@entry=0, deref=0)
at builtin/name-rev.c:138
<snip>...
#1047 0x00005642d10c74e3 in name_rev (commit=<optimized out>,
tip_name=tip_name@entry=0x5642d245e7c0 "master",
taggerdate=taggerdate@entry=1000799900, generation=generation@entry=1,
distance=distance@entry=1, from_tag=from_tag@entry=0, deref=0)
at builtin/name-rev.c:138
#1048 0x00005642d10c74e3 in name_rev (commit=commit@entry=0x5642d22e6420,
tip_name=0x5642d245e7c0 "master", taggerdate=taggerdate@entry=1000799900,
generation=generation@entry=0, distance=distance@entry=0,
from_tag=from_tag@entry=0, deref=0) at builtin/name-rev.c:138
#1049 0x00005642d10c7889 in name_ref (path=<optimized out>,
oid=0x5642d2465bd8, flags=<optimized out>, cb_data=<optimized out>)
at builtin/name-rev.c:276
#1050 0x00005642d11d5074 in do_for_each_repo_ref_iterator (
r=0x5642d1546de0 <the_repo>, iter=0x5642d245da20,
fn=fn@entry=0x5642d11cab10 <do_for_each_ref_helper>,
cb_data=cb_data@entry=0x7ffc71fffa90) at refs/iterator.c:418
#1051 0x00005642d11cc7eb in do_for_each_ref (refs=<optimized out>,
prefix=prefix@entry=0x5642d12a0450 "",
fn=fn@entry=0x5642d10c75f0 <name_ref>, trim=trim@entry=0,
flags=flags@entry=0, cb_data=cb_data@entry=0x7ffc71fffb40) at refs.c:1496
#1052 0x00005642d11cd488 in refs_for_each_ref (cb_data=0x7ffc71fffb40,
fn=0x5642d10c75f0 <name_ref>, refs=<optimized out>) at refs.c:1502
#1053 for_each_ref (fn=fn@entry=0x5642d10c75f0 <name_ref>,
cb_data=cb_data@entry=0x7ffc71fffb40) at refs.c:1507
#1054 0x00005642d10c7ec5 in cmd_name_rev (argc=<optimized out>,
argv=0x7ffc71fffb40, prefix=<optimized out>) at builtin/name-rev.c:490
#1055 0x00005642d1070d68 in run_builtin (argv=<optimized out>,
argc=<optimized out>, p=<optimized out>) at git.c:444
#1056 handle_builtin (argc=2, argv=0x7ffc72000ac0) at git.c:675
#1057 0x00005642d1071d1e in run_argv (argv=0x7ffc72000840,
argcp=0x7ffc7200084c) at git.c:742
#1058 cmd_main (argc=<optimized out>, argv=<optimized out>) at git.c:876
#1059 0x00005642d107094a in main (argc=3, argv=0x7ffc72000ab8)
at common-main.c:50
(gdb) quit
next reply other threads:[~2019-05-11 20:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 20:57 Eric Wong [this message]
2019-05-11 22:31 ` new segfault in master (6a6c0f10a70a6eb1) Jeff King
2019-05-11 23:02 ` Jeff King
2019-05-12 4:26 ` Duy Nguyen
2019-05-14 13:54 ` [PATCH] get_oid: handle NULL repo->index Jeff King
2019-05-14 23:38 ` Eric Wong
2019-05-15 1:24 ` Duy Nguyen
2019-05-15 1:46 ` Jeff King
2019-05-15 5:16 ` Junio C Hamano
2019-05-15 9:29 ` Duy Nguyen
2019-05-16 1:43 ` Junio C Hamano
2019-05-19 2:56 ` [PATCH] repository.c: always allocate 'index' at repo init time Nguyễn Thái Ngọc Duy
2019-05-20 13:17 ` Jeff King
2019-05-21 10:34 ` Duy Nguyen
2019-05-21 20:58 ` Jeff King
2019-05-28 16:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511205711.tdclwrdixaau75zv@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).