git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Emily Shaffer <emilyshaffer@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v5 1/2] documentation: add tutorial for first contribution
Date: Wed, 8 May 2019 11:58:07 -0700	[thread overview]
Message-ID: <20190508185807.GA14000@google.com> (raw)
In-Reply-To: <xmqqimulip5k.fsf@gitster-ct.c.googlers.com>

On Wed, May 08, 2019 at 12:46:47PM +0900, Junio C Hamano wrote:
> Emily Shaffer <emilyshaffer@google.com> writes:
> 
> > +=== Clone the Git Repository
> > +
> > +Git is mirrored in a number of locations. Clone the repository from one of them;
> > +https://git-scm.com/downloads suggests one of the best places to clone from is
> > +the official mirror on GitHub.
> 
> I didn't want to have to get into fine-grained wordsmithing (let
> alone bikeshedding) this late in the iteration of the topic, but
> "the official mirror" is not something anybody suggested in the
> recent reviews (JTan's rephrasing, which I already said that I am OK
> with, said something like "one of the many mirrors").

I should have waited longer on sending this round of patch out; as it
stands I sent the patch with this fix a few hours before your response
to JTan came out. Sorry for the confusion.

> And "official" is a phrase I have trouble with in this context.  A
> mirror does not have to be blessed as official; that's the point of
> a mirror---anybody can make one to help users with better
> connectivity or availability, as long as its users trust the mirror
> maintainer for mirror's correctness and freshness.

You're right and I'll remove it. However, I've seen at least one
instance of confusion over Git's lack of an "official" mirror (over on
#git on Freenode). I'd like to rephrase this to explain the reasoning
behind having multiple mirrors, none of which are official.

To that end, I propose replacing the phrase with "one of the best places
to clone from is this mirror on GitHub." followed by the clone command
to git/git, then followed by:

	NOTE: As Git is a distributed version control, the Git project also
	follows a distributed model. There is no central official mirror; any
	mirror which you can reasonably trust is being kept correct and fresh to
	the Git source distributed by the Git maintainer is fine to work from.

What do we think?

Alternatively, if the desire is to just be done with it, I have no
problem with Junio rewording however he feels is best and otherwise
applying this patch - if there is value in reducing the churn on the
mailing list for this patch.

> So perhaps "... clone from is the mirror maintained by GitHub folks"
> or just simply "is the mirror on GitHub"?
> 
> > +$ git send-email --to=target@example.com
> > +		 --in-reply-to="<foo.12345.author@example.com>"
> 
> Very nice attention to the detail here.  I like it (the earlier
> round did not have dq around the message ID).
> 
> > +		 psuh/v2*
> > +----
> 
> All other edits relative to the previous round look very sensible to
> me.  Thanks.

  reply	other threads:[~2019-05-08 18:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 18:32 [PATCH 0/1] documentation: add lab for first contribution Emily Shaffer via GitGitGadget
2019-04-11 18:32 ` [PATCH 1/1] " Emily Shaffer via GitGitGadget
2019-04-12  3:20   ` Junio C Hamano
2019-04-12 22:03     ` Emily Shaffer
2019-04-13  5:39       ` Junio C Hamano
2019-04-15 17:26         ` Emily Shaffer
2019-04-11 21:03 ` [PATCH 0/1] " Josh Steadmon
2019-04-12  2:35 ` Junio C Hamano
2019-04-12 22:58   ` Emily Shaffer
2019-04-16 20:26 ` [PATCH v2 " Emily Shaffer via GitGitGadget
2019-04-16 20:26   ` [PATCH v2 1/1] " Emily Shaffer via GitGitGadget
2019-04-17  5:32     ` Junio C Hamano
2019-04-17  8:07       ` Eric Sunshine
2019-04-18  0:05         ` Junio C Hamano
2019-04-17 23:16       ` Emily Shaffer
2019-04-16 21:13   ` [PATCH v2 0/1] " Emily Shaffer
2019-04-19 16:57   ` [PATCH v3] " Emily Shaffer
2019-04-21 10:52     ` Junio C Hamano
2019-04-22 22:27       ` Emily Shaffer
2019-04-23 19:34     ` [PATCH v4] documentation: add tutorial " Emily Shaffer
2019-04-30 18:59       ` Josh Steadmon
2019-05-02  0:57         ` Emily Shaffer
2019-05-03  2:11       ` Phil Hord
2019-05-07 19:05         ` Emily Shaffer
2019-05-06 22:28       ` Jonathan Tan
2019-05-07 19:59         ` Emily Shaffer
2019-05-07 20:32           ` Jonathan Tan
2019-05-08  2:45         ` Junio C Hamano
2019-05-07 21:30       ` [PATCH v5 0/2] documentation: add lab " Emily Shaffer
2019-05-07 21:30         ` [PATCH v5 1/2] documentation: add tutorial " Emily Shaffer
2019-05-07 23:25           ` Emily Shaffer
2019-05-08  3:46           ` Junio C Hamano
2019-05-08 18:58             ` Emily Shaffer [this message]
2019-05-08 19:53               ` Jonathan Tan
2019-05-07 21:30         ` [PATCH v5 2/2] documentation: add anchors to MyFirstContribution Emily Shaffer
2019-05-08  3:30         ` [PATCH v5 0/2] documentation: add lab for first contribution Junio C Hamano
2019-05-17 19:03         ` [PATCH v6 0/2] documentation: add tutorial " Emily Shaffer
2019-05-17 19:07           ` [PATCH v6 1/2] " Emily Shaffer
2019-05-26  7:48             ` Christian Couder
2019-05-29 20:09               ` Emily Shaffer
2019-10-18 16:40             ` SZEDER Gábor
2019-10-18 22:54               ` Emily Shaffer
2019-05-17 19:07           ` [PATCH v6 2/2] documentation: add anchors to MyFirstContribution Emily Shaffer
2019-05-29 20:18           ` [PATCH] doc: add some nit fixes " Emily Shaffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508185807.GA14000@google.com \
    --to=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).