From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Julia Lawall <julia.lawall@lip6.fr>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH 2/2] diffcore-pickaxe: add --pickaxe-raw-diff for use with -G
Date: Fri, 3 May 2019 11:10:49 +0200 [thread overview]
Message-ID: <20190503091049.GA6438@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <87ftq6s252.fsf@evledraar.gmail.com>
On Thu, Apr 25, 2019 at 02:25:13PM +0200, Ævar Arnfjörð Bjarmason wrote:
[..]
> Do you or anyone have a suggestion for a better CLI option name?
>
> Maybe --pickaxe-patch or --pickaxe-patch-format (to go with git-diff's
> -u aka --patch (i.e. not --raw) default format)? Or
> --pickaxe-G-with-context or --pickaxe-with-context or
> --with-pickaxe-context or --pickaxe-context ? All of these suck, but I'm
> coming up blank on a better one :)
'--pickaxe-patch' is shorter than '--pickaxe-raw-diff', hence more
convenient to me. It looks like 'pickaxe-all' and 'pickaxe-regex' are
the only --pickaxe-* options currently implemented. Both of them are
two-worded only and easy to remember/type. I think '--pickaxe-patch'
is more user-friendly, but I leave git people to say the final word.
>
> Probably the least shitty of those shitty options is --pickaxe-patch,
> since we have --patch which triggers the same format, and we can
> document that the default is a -G search through --no-pickaxe-patch, and
> you can just tweak the format.
>
> It also leaves the door open (unlike having *-G-* in the option) to
> support this for -S if anyone cared...
--
Best Regards,
Eugeniu.
next prev parent reply other threads:[~2019-05-03 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 10:26 Multi-line 'git log -G<regex>'? Eugeniu Rosca
2019-04-24 15:22 ` [PATCH 0/2] diffcore-pickaxe: implement --pickaxe-raw-diff Ævar Arnfjörð Bjarmason
2019-04-24 15:22 ` [PATCH 1/2] diffcore-pickaxe: refactor !one or !two case in diff_grep Ævar Arnfjörð Bjarmason
2019-04-24 15:22 ` [PATCH 2/2] diffcore-pickaxe: add --pickaxe-raw-diff for use with -G Ævar Arnfjörð Bjarmason
2019-04-24 15:37 ` Ævar Arnfjörð Bjarmason
2019-04-24 22:46 ` Eugeniu Rosca
2019-04-24 23:24 ` Ævar Arnfjörð Bjarmason
2019-04-25 0:44 ` Junio C Hamano
2019-04-25 12:25 ` Ævar Arnfjörð Bjarmason
2019-05-03 9:10 ` Eugeniu Rosca [this message]
2019-05-03 8:37 ` Eugeniu Rosca
2019-04-25 0:54 ` Eugeniu Rosca
2019-04-25 12:14 ` Ævar Arnfjörð Bjarmason
2019-05-03 3:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503091049.GA6438@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julia.lawall@lip6.fr \
--cc=peff@peff.net \
--cc=roscaeugeniu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).