From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0EC4F1F453 for ; Thu, 2 May 2019 02:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbfEBCwI (ORCPT ); Wed, 1 May 2019 22:52:08 -0400 Received: from cloud.peff.net ([104.130.231.41]:46628 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726152AbfEBCwI (ORCPT ); Wed, 1 May 2019 22:52:08 -0400 Received: (qmail 2712 invoked by uid 109); 2 May 2019 02:52:08 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 02 May 2019 02:52:08 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 25482 invoked by uid 111); 2 May 2019 02:52:42 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Wed, 01 May 2019 22:52:42 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 01 May 2019 22:52:06 -0400 Date: Wed, 1 May 2019 22:52:06 -0400 From: Jeff King To: Josh Steadmon Cc: Junio C Hamano , git@vger.kernel.org Subject: Re: js/partial-clone-connectivity-check (was: What's cooking in git.git (Apr 2019, #05; Thu, 25)) Message-ID: <20190502025206.GA25395@sigill.intra.peff.net> References: <20190425221657.GV60888@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190425221657.GV60888@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Apr 25, 2019 at 03:16:57PM -0700, Josh Steadmon wrote: > On 2019.04.25 19:15, Junio C Hamano wrote: > > * js/partial-clone-connectivity-check (2019-04-21) 1 commit > > (merged to 'next' on 2019-04-25 at ebd8b4bffd) > > + clone: do faster object check for partial clones > > > > During an initial "git clone --depth=..." partial clone, it is > > pointless to spend cycles for a large portion of the connectivity > > check that enumerates and skips promisor objects (which by > > definition is all objects fetched from the other side). This has > > been optimized out. > > > > Will merge to 'master'. > > Peff asked for a perf test for this [1], but I haven't had time to write one > yet. I can do that in a separate patch if you still want to merge this > as-is. I won't die without one, but it would be nice. It may also be that an existing perf test, but I don't think we cover partial clones in t/perf at all. Might be worth just a straight-up "git clone --filter=blob:none" test. Also, in the proposed merge message above, it should be --filter, not --depth, right? -Peff