From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeffrey Walton <noloader@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: install: gitweb.cgi was not found anywhere
Date: Wed, 1 May 2019 15:30:05 -0700 [thread overview]
Message-ID: <20190501223005.GB42435@google.com> (raw)
In-Reply-To: <CAH8yC8kec2N0fkt6cWChOEGtGkrOE5S+QuZnQnDP1eM9mg_EOQ@mail.gmail.com>
Hi,
Jeffrey Walton wrote:
> I'm attempting to install Git 2.21.0 on Solaris 11.3 x86_64.
> /usr/gnu/bin is on-path.
[...]
> gmake -C gitweb install
> gmake[1]: Entering directory `/export/home/build/git-2.21.0/gitw
> eb'
> gmake[2]: Entering directory `/export/home/build/git-2.21.0'
> gmake[2]: `GIT-VERSION-FILE' is up to date.
> gmake[2]: Leaving directory `/export/home/build/git-2.21.0'
> GEN gitweb.cgi
> GEN static/gitweb.js
> install -d -m 755 '/usr/local/share/gitweb'
> directory /usr/local/share/gitweb created
> install -m 755 gitweb.cgi '/usr/local/share/gitweb'
> find: cycle detected for /lib/secure/32/
[...]
> install: gitweb.cgi was not found anywhere!
Sounds like it's using "install" when it should be using "ginstall".
config.mak.uname contains, under the SunOS category:
INSTALL = /usr/ucb/install
But gitweb/Makefile seems to forget to include ../config.mak.uname.
How about this patch?
-- >8 --
Subject: gitweb: use system-appropriate defaults for commands
Attempting to install gitweb on Solaris 11 produces
$ gmake install
...
gmake -C gitweb install
gmake[1]: Entering directory `/export/home/build/git-2.21.0/gitweb'
gmake[2]: Entering directory `/export/home/build/git-2.21.0'
gmake[2]: `GIT-VERSION-FILE' is up to date.
gmake[2]: Leaving directory `/export/home/build/git-2.21.0'
GEN gitweb.cgi
GEN static/gitweb.js
install -d -m 755 '/usr/local/share/gitweb'
directory /usr/local/share/gitweb created
install -m 755 gitweb.cgi '/usr/local/share/gitweb'
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/32/
find: cycle detected for /lib/crypto/32/
...
find: cycle detected for /usr/lib/gss/32/
install: gitweb.cgi was not found anywhere!
gmake[1]: *** [install] Error 2
gmake[1]: Leaving directory `/export/home/build/git-2.21.0/gitweb'
This is because the default "install" tool on SunOS doesn't follow the
convention we require. Use the /usr/ucb/install command specified in
config.mak.uname instead to fix it.
This should also help on other platforms where the default "install"
command is not functional enough.
Reported-by: Jeffrey Walton <noloader@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Completely untested. Junio, please don't apply this without Jeffrey's
tested-by.
Thanks,
Jonathan
gitweb/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index cd194d057f..333aa58be0 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -39,7 +39,7 @@ GITWEB_SITE_HEADER =
GITWEB_SITE_FOOTER =
HIGHLIGHT_BIN = highlight
-# include user config
+include ../config.mak.uname
-include ../config.mak.autogen
-include ../config.mak
-include config.mak
--
2.21.0.1020.gf2820cf01a
next prev parent reply other threads:[~2019-05-01 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 21:57 Jeffrey Walton
2019-05-01 22:30 ` Jonathan Nieder [this message]
2019-05-01 22:55 ` install: gitweb.cgi was not found anywhere Jeffrey Walton
2019-05-02 18:35 ` Jeffrey Walton
2019-05-03 20:56 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501223005.GB42435@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=noloader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).