From: santiago@nyu.edu
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, sunshine@sunshineco.com,
walters@verbum.org, Santiago Torres <santiago@nyu.edu>
Subject: [PATCH 1/2] builtin/tag: do not omit -v gpg out for --format
Date: Sat, 27 Apr 2019 16:21:22 -0400 [thread overview]
Message-ID: <20190427202123.15380-2-santiago@nyu.edu> (raw)
In-Reply-To: <20190427202123.15380-1-santiago@nyu.edu>
From: Santiago Torres <santiago@nyu.edu>
The current implementation of git tag -v omits the gpg output when the
--format flag is passed. This may not be useful to users that want to
see the gpg output *and* --format the output of the git tag -v. Instead,
pass the default gpg interface output if --format is specified.
Signed-off-by: Santiago Torres <santiago@nyu.edu>
---
builtin/tag.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 02f6bd1279..449d91c13c 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -110,10 +110,10 @@ static int verify_tag(const char *name, const char *ref,
{
int flags;
const struct ref_format *format = cb_data;
- flags = GPG_VERIFY_VERBOSE;
+ flags = 0;
- if (format->format)
- flags = GPG_VERIFY_OMIT_STATUS;
+ if (!format->format)
+ flags = GPG_VERIFY_VERBOSE;
if (gpg_verify_tag(oid, name, flags))
return -1;
--
2.21.0
next prev parent reply other threads:[~2019-04-27 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 20:21 [PATCH 0/2] tag verification: do not mute gpg output santiago
2019-04-27 20:21 ` santiago [this message]
2019-05-09 7:36 ` [PATCH 1/2] builtin/tag: do not omit -v gpg out for --format Jeff King
2019-05-09 17:36 ` Santiago Torres Arias
2019-04-27 20:21 ` [PATCH 2/2] builtin/verify-tag: do not omit gpg on --format santiago
2019-05-09 7:44 ` Jeff King
2019-05-09 17:40 ` Santiago Torres Arias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427202123.15380-2-santiago@nyu.edu \
--to=santiago@nyu.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).