From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 62E3D1F5CB for ; Mon, 22 Apr 2019 16:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfDVQCO (ORCPT ); Mon, 22 Apr 2019 12:02:14 -0400 Received: from cloud.peff.net ([104.130.231.41]:36892 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726098AbfDVQCN (ORCPT ); Mon, 22 Apr 2019 12:02:13 -0400 Received: (qmail 31413 invoked by uid 109); 22 Apr 2019 16:02:14 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 22 Apr 2019 16:02:14 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 32626 invoked by uid 111); 22 Apr 2019 16:02:45 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 22 Apr 2019 12:02:45 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 22 Apr 2019 12:02:11 -0400 Date: Mon, 22 Apr 2019 12:02:11 -0400 From: Jeff King To: Santiago Torres Arias Cc: git@vger.kernel.org, gitster@pobox.com, sunshine@sunshineco.us Subject: Re: [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty Message-ID: <20190422160211.GB9680@sigill.intra.peff.net> References: <20190412201432.11328-1-santiago@nyu.edu> <20190422152726.GB1633@sigill.intra.peff.net> <20190422154655.sxyrkee7rnywoh2w@LykOS.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190422154655.sxyrkee7rnywoh2w@LykOS.localdomain> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Apr 22, 2019 at 11:46:56AM -0400, Santiago Torres Arias wrote: > > In some ways I'm less concerned about verify-tag, though, because the > > point is that it should be scriptable. And scraping gpg's stderr is not > > ideal there. We should be parsing --status-fd ourselves and making the > > result available via format specifier, similar to the way "log > > --format=%G?" works. > > I think that would be great, as we could make it simpler for verifiers > to parse gpg output. Alternatively, we could make it an option to dump the --status-fd output to stderr (or to a custom fd). That still leaves the caller with the responsibility to parse gpg's output, but at least they're parsing the machine-readable bits and not the regular human-readable stderr. -Peff