From: Jeff King <peff@peff.net>
To: santiago@nyu.edu
Cc: git@vger.kernel.org, gitster@pobox.com, sunshine@sunshineco.com
Subject: Re: [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty
Date: Mon, 22 Apr 2019 11:27:26 -0400 [thread overview]
Message-ID: <20190422152726.GB1633@sigill.intra.peff.net> (raw)
In-Reply-To: <20190412201432.11328-1-santiago@nyu.edu>
On Fri, Apr 12, 2019 at 04:14:32PM -0400, santiago@nyu.edu wrote:
> From: Santiago Torres <santiago@nyu.edu>
>
> On the git tag -v code, there is a guard to suppress gpg output if a
> pretty format is provided. The rationale for this is that the gpg output
> *and* the pretty formats together may conflict with each other. However,
> both outputs are directed to different output streams and, as such,
> they can safely coexist. Drop the guard clause and use
> GPG_VERIFY_VERBOSE regardless of the pretty format
I think this makes sense. My first worry was whether this would be
surprising to any callers, but as you note, they go to different
streams.
However, I don't think this patch is quite right, as it causes us to
dump the whole tag contents to stdout, as well. E.g.:
[before]
$ git tag -v --format='foo %(tag)' v2.21.0
foo v2.21.0
[after]
$ git tag -v --format='foo %(tag)' v2.21.0
object 8104ec994ea3849a968b4667d072fedd1e688642
type commit
tag v2.21.0
tagger Junio C Hamano <gitster@pobox.com> 1551023739 -0800
Git 2.21
gpg: Signature made Sun Feb 24 10:55:39 2019 EST
gpg: using RSA key E1F036B1FEE7221FC778ECEFB0B5E88696AFE6CB
gpg: Good signature from "Junio C Hamano <gitster@pobox.com>" [full]
gpg: aka "Junio C Hamano <jch@google.com>" [full]
gpg: aka "Junio C Hamano <junio@pobox.com>" [full]
foo v2.21.0
I think "git verify-tag" would need similar treatment, too:
$ git verify-tag v2.21.0
gpg: Signature made Sun Feb 24 10:55:39 2019 EST
gpg: using RSA key E1F036B1FEE7221FC778ECEFB0B5E88696AFE6CB
gpg: Good signature from "Junio C Hamano <gitster@pobox.com>" [full]
gpg: aka "Junio C Hamano <jch@google.com>" [full]
gpg: aka "Junio C Hamano <junio@pobox.com>" [full]
$ git verify-tag --format='foo %(tag)' v2.21.0
foo v2.21.0
In some ways I'm less concerned about verify-tag, though, because the
point is that it should be scriptable. And scraping gpg's stderr is not
ideal there. We should be parsing --status-fd ourselves and making the
result available via format specifier, similar to the way "log
--format=%G?" works.
So I think ultimately that's the direction we want to go, but I think
in the meantime restoring the gpg output to stderr especially for the
porcelain "git tag -v" makes sense for human eyes.
-Peff
next prev parent reply other threads:[~2019-04-22 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 20:14 [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty santiago
2019-04-12 20:16 ` Santiago Torres Arias
2019-04-22 15:27 ` Jeff King [this message]
2019-04-22 15:46 ` Santiago Torres Arias
2019-04-22 16:02 ` Jeff King
2019-04-22 23:07 ` brian m. carlson
2019-04-22 23:26 ` Santiago Torres Arias
2019-04-23 0:00 ` brian m. carlson
2019-04-23 2:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422152726.GB1633@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).