mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: Junio C Hamano <>
Subject: Re: [PATCH/RFC] Makefile: dedup list of files obtained from ls-files
Date: Mon, 22 Apr 2019 10:49:27 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Apr 21, 2019 at 10:19:04PM +0900, Junio C Hamano wrote:

>    I am not fan of adding the "| sort -u" of the whole thing,
>    because there is no need to dedup the output of the $(FIND) side
>    of the alternative, but "(ls-files | sort -u) || (find)" would
>    obviously not work.  If we truly care, perhaps we should add a
>    new option to ls-files to show each path only once, unless it is
>    showing the stage number (i.e. "ls-files -s" or "ls-files -u"),
>    but this gets the problem go away without code change, hence this
>    RFC ;-)

FWIW, after reading your commit message my thoughts immediately turned
to "why can't ls-files have a mode that outputs each just once", but
then ended up at the same place as your patch: it's not that hard to
just de-dup the output.

It _could_ be a sign that other scripts besides our Makefile would
benefit from such an option, but I think I'd want to see at least one
other example before going in that direction.

So the patch itself looks good to me (though I agree that Eric's
suggestion to de-dup inside "make" is better still).


  parent reply	other threads:[~2019-04-22 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21 13:19 [PATCH/RFC] Makefile: dedup list of files obtained from ls-files Junio C Hamano
2019-04-22  3:23 ` Eric Sunshine
2019-04-22  6:11   ` Junio C Hamano
2019-04-22 14:49 ` Jeff King [this message]
2019-04-22 17:15   ` Ramsay Jones
2019-04-23  1:18     ` Junio C Hamano
2019-04-23 20:21   ` SZEDER Gábor
2019-04-24  1:03     ` Junio C Hamano
2019-04-24 11:25       ` SZEDER Gábor
2019-04-24 17:19         ` Eric Sunshine
2019-04-25  0:59           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).