git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Santiago Torres Arias <santiago@nyu.edu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, sunshine@sunshineco.com
Subject: Re: [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty
Date: Fri, 12 Apr 2019 16:16:10 -0400
Message-ID: <20190412201609.hivppg2l37b6pzze@LykOS.localdomain> (raw)
In-Reply-To: <20190412201432.11328-1-santiago@nyu.edu>

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Fri, Apr 12, 2019 at 04:14:32PM -0400, santiago@nyu.edu wrote:
> From: Santiago Torres <santiago@nyu.edu>
> 
> On the git tag -v code, there is a guard to suppress gpg output if a
> pretty format is provided. The rationale for this is that the gpg output
> *and* the pretty formats together may conflict with each other. However,
> both outputs are directed to different output streams and, as such,
> they can safely coexist. Drop the guard clause and use
> GPG_VERIFY_VERBOSE regardless of the pretty format

I tried digging for the rationale for this, but I couldn't figure it
out. I noticed that the output of gpg verification is sent to stderr,
while the pretty format goes towards stdout, and they can thus be
multiplexed accordingly.

What do you guys think?

Thanks!
-Santiago.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 20:14 santiago
2019-04-12 20:16 ` Santiago Torres Arias [this message]
2019-04-22 15:27 ` Jeff King
2019-04-22 15:46   ` Santiago Torres Arias
2019-04-22 16:02     ` Jeff King
2019-04-22 23:07       ` brian m. carlson
2019-04-22 23:26         ` Santiago Torres Arias
2019-04-23  0:00           ` brian m. carlson
2019-04-23  2:13         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412201609.hivppg2l37b6pzze@LykOS.localdomain \
    --to=santiago@nyu.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git