From: Jeff King <peff@peff.net>
To: "Bárbara de Castro Fernandes" <barbara.fernandes@usp.br>
Cc: Robert Dailey <rcdailey.lists@gmail.com>,
Taylor Blau <me@ttaylorr.com>, Git <git@vger.kernel.org>
Subject: Re: Feature request: Add --no-edit to git tag command
Date: Thu, 11 Apr 2019 14:29:03 -0400 [thread overview]
Message-ID: <20190411182903.GA32528@sigill.intra.peff.net> (raw)
In-Reply-To: <CAJ+V80pY0L7onX600dmSaMuFFnH5n52-3CmnRyDKr-7ZkZ92mA@mail.gmail.com>
On Thu, Apr 11, 2019 at 03:20:52PM -0300, Bárbara de Castro Fernandes wrote:
> This new proposed --amend option, although semantically different,
> would have a very similar functionality to the already existing -f
> option. So should we, perhaps, change -f's behavior to treat the tag
> as a new one, treating the old one as if it never existed (as I think
> Junio was saying)? By this I mean the command should fail if the user
> doesn't give a SHA-1 and the previous message wouldn't be preloaded.
> --amend, on the other hand, would give the user an opportunity to
> revise the tag by opening, by default, the editor with the
> pre-existing message unless given the '--no-edit' option, and if not
> given a SHA-1 it would keep on using the previous one.
Yes, that's what I'd expect it to do (so yes, it's also different from
"-f" in that it defaults to the existing tag destination instead of
HEAD).
-Peff
next prev parent reply other threads:[~2019-04-11 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:38 Feature request: Add --no-edit to git tag command Robert Dailey
2019-04-04 1:57 ` Jeff King
2019-04-04 3:26 ` Taylor Blau
2019-04-04 12:06 ` Jeff King
2019-04-04 13:56 ` Robert Dailey
2019-04-04 13:57 ` Robert Dailey
2019-04-05 22:21 ` Jeff King
2019-04-11 18:20 ` Bárbara de Castro Fernandes
2019-04-11 18:29 ` Jeff King [this message]
2019-04-12 2:32 ` Junio C Hamano
2019-04-12 2:33 ` Jeff King
2019-04-04 9:13 ` Junio C Hamano
2019-04-04 12:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411182903.GA32528@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barbara.fernandes@usp.br \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=rcdailey.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).