From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org, peff@peff.net, jonathantanmy@google.com,
jrnieder@gmail.com
Subject: Re: [PATCH v3] rev-list: exclude promisor objects at walk time
Date: Tue, 9 Apr 2019 20:04:18 +0200 [thread overview]
Message-ID: <20190409180418.GH8796@szeder.dev> (raw)
In-Reply-To: <9856e7fc74f51b60ae162cbed3f5c0cf8c603222.1554757275.git.steadmon@google.com>
On Mon, Apr 08, 2019 at 02:06:04PM -0700, Josh Steadmon wrote:
> For large repositories, enumerating the list of all promisor objects (in
> order to exclude them from a rev-list walk) can take a significant
> amount of time).
>
> When --exclude-promisor-objects is passed to rev-list, don't enumerate
> the promisor objects. Instead, filter them (and any children objects)
> during the actual graph walk.
>
> Remove the mark_uninteresting() function as it's not used anywhere else.
>
> When testing against a large repo [1], this patch reduces the
> connectivity check runtime from 3 minutes to ~7 seconds.
This patch breaks test 'repack -d does not irreversibly delete
promisor objects' in 't0410-partial-clone.sh' when run with
GIT_TEST_COMMIT_GRAPH=1.
+rm -rf repo
+test_create_repo repo
+test 1 = 1
+repo=repo
+mkdir -p repo
+cd repo
+/home/travis/build/git/git/t/../git init --template=/home/travis/build/git/git/t/../templates/blt/
Initialized empty Git repository in /home/travis/build/git/git/t/trash directory.t0410-partial-clone/repo/.git/
+mv .git/hooks .git/hooks-disabled
+git -C repo config core.repositoryformatversion 1
+git -C repo config extensions.partialclone arbitrary string
+git -C repo commit --allow-empty -m one
[master (root-commit) 71905df] one
Author: A U Thor <author@example.com>
+git -C repo commit --allow-empty -m two
[master 202c4a3] two
Author: A U Thor <author@example.com>
+git -C repo commit --allow-empty -m three
[master 4737577] three
Author: A U Thor <author@example.com>
+git -C repo commit --allow-empty -m four
[master d6ba7e0] four
Author: A U Thor <author@example.com>
+git -C repo rev-parse HEAD^^^
+ONE=71905dfcd543b7cbb0b4b66fbd20379e67220557
+git -C repo rev-parse HEAD^^
+TWO=202c4a3dd9a2dac927f056abb747cce9ea2eb67b
+git -C repo rev-parse HEAD^
+THREE=47375779ebcca4b422e3afdd14aa37a358081297
+pack_as_from_promisor
+printf 202c4a3dd9a2dac927f056abb747cce9ea2eb67b\n
+git -C repo pack-objects .git/objects/pack/pack
+HASH=2e675cd706e508d6c52a21d28cfcddde5ec02a06
+
+echo 2e675cd706e508d6c52a21d28cfcddde5ec02a06
2e675cd706e508d6c52a21d28cfcddde5ec02a06
+printf 47375779ebcca4b422e3afdd14aa37a358081297\n
+pack_as_from_promisor
+git -C repo pack-objects .git/objects/pack/pack
+HASH=31f7d2797549ab9b1c425a9e60eb2030481170e5
+
+echo 31f7d2797549ab9b1c425a9e60eb2030481170e5
31f7d2797549ab9b1c425a9e60eb2030481170e5
+delete_object repo 71905dfcd543b7cbb0b4b66fbd20379e67220557
+sed -e s|^..|&/|
+echo 71905dfcd543b7cbb0b4b66fbd20379e67220557
+rm repo/.git/objects/71/905dfcd543b7cbb0b4b66fbd20379e67220557
+repack_and_check -a 202c4a3dd9a2dac927f056abb747cce9ea2eb67b 47375779ebcca4b422e3afdd14aa37a358081297
+rm -rf repo2
+cp -r repo repo2
+git -C repo2 repack -a -d
warning: reflog of 'HEAD' references pruned commits
warning: reflog of 'refs/heads/master' references pruned commits
fatal: unable to read 71905dfcd543b7cbb0b4b66fbd20379e67220557
error: last command exited with $?=128
not ok 23 - repack -d does not irreversibly delete promisor objects
https://travis-ci.org/git/git/jobs/517874310#L5822
next prev parent reply other threads:[~2019-04-09 18:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 17:27 [PATCH] clone: do faster object check for partial clones Josh Steadmon
2019-04-03 18:58 ` Jonathan Tan
2019-04-03 19:41 ` Jeff King
2019-04-03 20:57 ` Jonathan Tan
2019-04-04 0:21 ` Josh Steadmon
2019-04-04 1:33 ` Jeff King
2019-04-04 22:53 ` [PATCH v2] rev-list: exclude promisor objects at walk time Josh Steadmon
2019-04-04 23:08 ` Jeff King
2019-04-04 23:47 ` Josh Steadmon
2019-04-05 0:00 ` Jeff King
2019-04-05 0:09 ` Josh Steadmon
2019-04-08 20:59 ` Josh Steadmon
2019-04-08 21:06 ` [PATCH v3] " Josh Steadmon
2019-04-08 22:23 ` Christian Couder
2019-04-08 23:12 ` Josh Steadmon
2019-04-09 15:14 ` Junio C Hamano
2019-04-09 15:15 ` Jeff King
2019-04-09 15:43 ` Junio C Hamano
2019-04-09 16:35 ` Josh Steadmon
2019-04-09 18:04 ` SZEDER Gábor [this message]
2019-04-09 23:42 ` Josh Steadmon
2019-04-11 4:06 ` Jeff King
2019-04-12 22:38 ` Josh Steadmon
2019-04-13 5:34 ` Jeff King
2019-04-19 20:26 ` Josh Steadmon
2019-04-19 21:00 ` [PATCH v4] clone: do faster object check for partial clones Josh Steadmon
2019-04-22 21:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409180418.GH8796@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).