* Bug: subcommand autocomplete fails on 2.21.0
@ 2019-04-06 16:36 Paul Schreiber
2019-04-06 17:49 ` SZEDER Gábor
0 siblings, 1 reply; 3+ messages in thread
From: Paul Schreiber @ 2019-04-06 16:36 UTC (permalink / raw)
To: git
With git 2.21.0, tab completion no longer works for subcommands.
STEPS TO REPRODUCE
1. install git 2.21.0 from https://git-scm.com/download/mac
2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
2. git clone https://github.com/tj/git-extras
3. cd git-extras
4. sudo make install
5. change directory to a git repository
6. type "git del” and press [tab]
EXPECTED
line is changed to "git delete-merged-branches"
ACTUAL
[beep]
CONFIG
macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
git 2.21.0
git-extras 4.8.0-dev
REGRESSION
Works as expected with git 2.17.0.
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: subcommand autocomplete fails on 2.21.0
2019-04-06 16:36 Bug: subcommand autocomplete fails on 2.21.0 Paul Schreiber
@ 2019-04-06 17:49 ` SZEDER Gábor
2019-04-06 21:19 ` SZEDER Gábor
0 siblings, 1 reply; 3+ messages in thread
From: SZEDER Gábor @ 2019-04-06 17:49 UTC (permalink / raw)
To: Paul Schreiber; +Cc: git
On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:
> With git 2.21.0, tab completion no longer works for subcommands.
>
> STEPS TO REPRODUCE
> 1. install git 2.21.0 from https://git-scm.com/download/mac
> 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
> 2. git clone https://github.com/tj/git-extras
> 3. cd git-extras
> 4. sudo make install
By the looks of it, this installs five commands whose names start with
'del':
git-delete-branch
git-delete-merged-branches
git-delete-submodule
git-delete-tag
git-delta
If this is indeed the case, then ...
> 5. change directory to a git repository
> 6. type "git del” and press [tab]
>
> EXPECTED
> line is changed to "git delete-merged-branches"
... this behavior would, in fact, be a bug, because 'del' is the
unique prefix of those five commands.
> ACTUAL
> [beep]
And I think this is the right behavior, and on a second TAB it should
list all commands whose name starts with 'del'.
> CONFIG
> macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
> git 2.21.0
> git-extras 4.8.0-dev
>
> REGRESSION
> Works as expected with git 2.17.0.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: subcommand autocomplete fails on 2.21.0
2019-04-06 17:49 ` SZEDER Gábor
@ 2019-04-06 21:19 ` SZEDER Gábor
0 siblings, 0 replies; 3+ messages in thread
From: SZEDER Gábor @ 2019-04-06 21:19 UTC (permalink / raw)
To: Paul Schreiber; +Cc: git
On Sat, Apr 06, 2019 at 07:49:29PM +0200, SZEDER Gábor wrote:
> On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:
> > With git 2.21.0, tab completion no longer works for subcommands.
> >
> > STEPS TO REPRODUCE
> > 1. install git 2.21.0 from https://git-scm.com/download/mac
> > 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
> > 2. git clone https://github.com/tj/git-extras
> > 3. cd git-extras
> > 4. sudo make install
>
> By the looks of it, this installs five commands whose names start with
> 'del':
>
> git-delete-branch
> git-delete-merged-branches
> git-delete-submodule
> git-delete-tag
> git-delta
>
> If this is indeed the case, then ...
>
> > 5. change directory to a git repository
> > 6. type "git del” and press [tab]
> >
> > EXPECTED
> > line is changed to "git delete-merged-branches"
>
> ... this behavior would, in fact, be a bug, because 'del' is the
> unique prefix of those five commands.
Erm, let me rephrase, because this doesn't make sense:
... this behavior would, in fact, be a bug, because 'del' is the
common prefix of those five commands, so it can't be uniquely
completed.
> > ACTUAL
> > [beep]
>
> And I think this is the right behavior, and on a second TAB it should
> list all commands whose name starts with 'del'.
>
> > CONFIG
> > macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
> > git 2.21.0
> > git-extras 4.8.0-dev
> >
> > REGRESSION
> > Works as expected with git 2.17.0.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-06 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 16:36 Bug: subcommand autocomplete fails on 2.21.0 Paul Schreiber
2019-04-06 17:49 ` SZEDER Gábor
2019-04-06 21:19 ` SZEDER Gábor
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).