git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Julian Andres Klode <jak@jak-linux.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git List Mailing <git@vger.kernel.org>
Subject: Re: "Problems" with git format-patch --thread email header ordering
Date: Thu, 4 Apr 2019 20:06:53 +0200	[thread overview]
Message-ID: <20190404180653.curtoo7yot6tpqfk@jak-t480s> (raw)
In-Reply-To: <CAHk-=whe+R7fkTi0eBnhrBY=_k_du3e5dkNsVe=HgKXLoXekdg@mail.gmail.com>

On Fri, Mar 15, 2019 at 09:59:25AM -0700, Linus Torvalds wrote:
> On Thu, Mar 14, 2019 at 9:47 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Linus Torvalds <torvalds@linux-foundation.org> writes:
> >
> > > While it's true that header ordering isn't specified, there's a common
> > > "canonical" order that the headers are listed in. To quote rfc822:
> > > ...
> > >             body must occur AFTER  the  headers.   It  is  recommended
> > >             that,  if  present,  headers be sent in the order "Return-
> > >             Path", "Received", "Date",  "From",  "Subject",  "Sender",
> > >             "To", "cc", etc.
> >
> > I obviously won't do the last one myself, but if the issue is only
> > to swap from and date, then this may be sufficient, perhaps?
> 
> I'm not actually sure _what_ the order requirements for gmail are,
> since gmail itself doesn't seem to honor them. Does the order of the
> Message-ID header line matter, for example?
> 
> I don't think it's the order of the From/Date lines, actually, because
> google itself doesn't do that.
> 
> What Thomas Found out was that the exact same email with
> 
>     Message-Id/From/Date/Subject/To
> 
> (in that order) does not work, but
> 
>     Date/From/Subject/To/Message-Id
> 
> does work. Weird and "wonderful". But there might be a lot of other
> orderings that work or don't.
> 
> Having looked through some other emails, I know that
> 
>     From/To/Subject/Date/Message-Id
>     Subject/To/References/From/Message-ID/Date
> 
> also works.  Which makes me suspect that it's the Message-ID line that matters.

I also know that gmail rewrites the Message-ID / creates one if it is
missing or "odd" (such as ends in a .). It those probably makes sense
in that twisted world view to require that to be fairly late...

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en

  reply	other threads:[~2019-04-04 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 23:44 "Problems" with git format-patch --thread email header ordering Linus Torvalds
2019-03-15  4:47 ` Junio C Hamano
2019-03-15 16:59   ` Linus Torvalds
2019-04-04 18:06     ` Julian Andres Klode [this message]
2019-04-05  5:24       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404180653.curtoo7yot6tpqfk@jak-t480s \
    --to=jak@jak-linux.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).