From: Thomas Gummerer <t.gummerer@gmail.com>
To: Kapil Jain <jkapil.cs@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts
Date: Fri, 29 Mar 2019 19:07:41 +0000 [thread overview]
Message-ID: <20190329190741.GM32487@hank.intra.tgummerer.com> (raw)
In-Reply-To: <CAMknYEM3Tff7Z5HcdNT9-RDTf53RHi1_scpO8JVo3pAD3-0xSw@mail.gmail.com>
On 03/29, Kapil Jain wrote:
> On Fri, Mar 29, 2019 at 3:00 AM Thomas Gummerer <t.gummerer@gmail.com> wrote:
> >
> >
> > I had previously mentioned that this project was attempted already in
> > my email at [*1*]. Did you take a look at the thread I linked to
> > there, and the regex used? I still feel like that previous experience
> > is something you could learn from.
>
> I saw it, and the regex i have used is a little different from that one.
Right, so one thing you should definitely do is to compare the regex
there and the regex you have, and understand why there are differences
when they are trying to do the same thing. Using that knowledge you
should be able to improve the regex in your patch as well.
next prev parent reply other threads:[~2019-03-29 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 16:06 [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts Kapil Jain
2019-03-23 20:04 ` Christian Couder
2019-03-24 8:04 ` Kapil Jain
2019-03-24 9:19 ` Christian Couder
2019-03-24 10:04 ` Kapil Jain
2019-03-28 21:30 ` Thomas Gummerer
2019-03-29 12:13 ` Kapil Jain
2019-03-29 19:07 ` Thomas Gummerer [this message]
2019-03-24 8:45 ` [GSoC][RFC/PATCH 2/2] userdiff: added shell script support, clears test Kapil Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329190741.GM32487@hank.intra.tgummerer.com \
--to=t.gummerer@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jkapil.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).