From: Denton Liu <liu.denton@gmail.com>
To: Julian Cheng <julian.cheng@utoronto.ca>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [GSoC] [t9803]
Date: Wed, 27 Mar 2019 14:10:50 -0700 [thread overview]
Message-ID: <20190327211050.GA4062@dev-l> (raw)
In-Reply-To: <7BFDFF1D85B3B544BB69BB9AB23D479D01F4534A@arborexcasx3.UTORARBOR.UTORAD.Utoronto.ca>
Hi Julian,
On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> Hello Git Community,
>
> I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
>
> Main Project Quesctions
> I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
>
> Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
>
>
> Microproject Questions (test_path_is_*)
> I would like to improve t9803-git-p4-shell-metachars.sh
>
> On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
>
> To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?
When the tests run, they don't test your installation (the git you're
currently using in /usr/bin/git). They test the git you've built in the
project directory.
First of all, you should build the project. You should run "make" from
the top-level directory of git. This will fill the directory with git-*
executables. These are the actual binaries that will be tested.
Next, go into t/ and run "make" again to run all of the tests. You can
also run individual tests by doing something like
./t9803-git-p4-shell-metachars.sh, for example.
For even more details on testing, see t/README.
Also, some other helpful documentation to read include:
* Documentation/SubmittingPatches
* Documentation/CodingGuidelines
Hope this helps,
Denton
>
> Best,
> Julian
next prev parent reply other threads:[~2019-03-27 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 19:26 [GSoC] [t9803] Julian Cheng
2019-03-27 21:10 ` Denton Liu [this message]
2019-03-27 22:04 ` Julian Cheng
2019-03-27 22:51 ` Denton Liu
2019-03-27 23:01 ` Julian Cheng
2019-03-27 23:32 ` Denton Liu
2019-04-18 21:07 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327211050.GA4062@dev-l \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=julian.cheng@utoronto.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).