git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>,
	Joel Teichroeb <joel@teichroeb.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	Matthew Kraai <mkraai@its.jnj.com>,
	Thomas Gummerer <t.gummerer@gmail.com>
Subject: [REGRESSION ps/stash-in-c] git stash show -v
Date: Tue, 19 Mar 2019 12:05:03 -0700	[thread overview]
Message-ID: <20190319190503.GA10066@dev-l> (raw)

Hi all,

I've been using jch's branch and I discovered a regression in
ps/stash-in-c.

Here's a test-case on git.git:

	echo '/**/' >>abspath.c
	git stash
	git stash show -v
	# I am expecting the diff to show up here

I am expecting the diff to show up but in reality, I get no output.
However, if I compile the latest master, the diff does show up.

Note that I can get the patch to show up using "git stash show -p" so
it's not really a showstopper. However, my understanding is that this
was supposed to be a one-to-one (bug included!) port.

Please let me know if we're keeping this behaviour so I can retrain my
fingers.

Thanks,

Denton

             reply	other threads:[~2019-03-19 19:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 19:05 Denton Liu [this message]
2019-03-19 23:18 ` [REGRESSION ps/stash-in-c] git stash show -v Thomas Gummerer
2019-03-20  1:00   ` Junio C Hamano
2019-03-20 21:45     ` Thomas Gummerer
2019-03-20  1:04   ` Junio C Hamano
2019-03-20  5:04   ` Jeff King
2019-03-20  9:30     ` Duy Nguyen
2019-03-20 21:59     ` Thomas Gummerer
2019-03-20 22:49   ` [PATCH v2] stash: setup default diff output format if necessary Thomas Gummerer
2019-03-20 23:04     ` Denton Liu
2019-03-20 23:09     ` Denton Liu
2019-03-28 20:45       ` Thomas Gummerer
2019-03-21  9:51     ` Jeff King
2019-03-22  3:25       ` Junio C Hamano
2019-03-22  3:48         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319190503.GA10066@dev-l \
    --to=liu.denton@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=joel@teichroeb.net \
    --cc=mkraai@its.jnj.com \
    --cc=t.gummerer@gmail.com \
    --cc=ungureanupaulsebastian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).