From: "Torsten Bögershausen" <tboegi@web.de>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git@vger.kernel.org, jeffhost@microsoft.com
Subject: Re: [PATCH v1 1/1] trace2: NULL is not allowed for va_list
Date: Mon, 18 Mar 2019 15:54:59 +0000 [thread overview]
Message-ID: <20190318155459.nrog5r5y3ci3bz3x@tb-raspi4> (raw)
In-Reply-To: <30c8b265-d6bf-3265-b2ae-029aa60d63e5@jeffhostetler.com>
On Mon, Mar 18, 2019 at 08:35:26AM -0400, Jeff Hostetler wrote:
>
>
> On 3/16/2019 6:47 AM, tboegi@web.de wrote:
> > From: Torsten Bögershausen <tboegi@web.de>
> >
> > Some compilers don't allow NULL to be passed for a va_list.
> > Use va_list instead.
> >
> > Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>
> Thanks for the fixup.
>
> For future reference, can you elaborate on which compiler
> and/or platform has the problem ?
>
> Jeff
It is on a Raspberry PI:
gcc (Raspbian 6.3.0-18+rpi1+deb9u1) 6.3.0 20170516
trace2/tr2_tgt_event.c:193:18: error: invalid operands to binary && (have ‘int’ and ‘va_list {aka __va_list}’)
if (fmt && *fmt && ap) {
~~~~~~~~~~~ ^~
(And I couldn't find any hints that va_list and pointers can be mixed,
and no hints that they can't either)
next prev parent reply other threads:[~2019-03-18 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 10:47 [PATCH v1 1/1] trace2: NULL is not allowed for va_list tboegi
2019-03-18 6:18 ` Junio C Hamano
2019-03-18 12:35 ` Jeff Hostetler
2019-03-18 15:54 ` Torsten Bögershausen [this message]
2019-03-18 17:58 ` Morten Welinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318155459.nrog5r5y3ci3bz3x@tb-raspi4 \
--to=tboegi@web.de \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).