From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Jeffrey Walton <noloader@gmail.com>,
Todd Zullinger <tmz@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: fix unaligned loads in sha1dc with UBSan
Date: Tue, 12 Mar 2019 17:19:08 -0400 [thread overview]
Message-ID: <20190312211908.GA24509@sigill.intra.peff.net> (raw)
In-Reply-To: <87va0nbxmj.fsf@evledraar.gmail.com>
On Tue, Mar 12, 2019 at 10:17:56PM +0100, Ævar Arnfjörð Bjarmason wrote:
> > Here's a commit which updates Git to use the new feature. I've tested it
> > with both the in-tree and submodule builds like:
> >
> > make DC_SHA1_SUBMODULE=Yes SANITIZE=undefined && (cd t && ./t0001-*)
> > make DC_SHA1_SUBMODULE= SANITIZE=undefined && (cd t && ./t0001-*)
> >
> > both of which fail without this patch and succeed without it.
>
> FWIW I've reproduced this testing and found the same thing. Looks good
> to me.
Er, that second "without" should be "with", but hopefully you figured
that out during your testing. :)
-Peff
next prev parent reply other threads:[~2019-03-12 21:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 10:48 One failed self test on Fedora 29 Jeffrey Walton
2019-03-08 17:43 ` Todd Zullinger
2019-03-09 12:34 ` Jeffrey Walton
2019-03-09 13:12 ` Jeffrey Walton
2019-03-11 2:00 ` Junio C Hamano
2019-03-11 2:16 ` Jeffrey Walton
2019-03-11 3:37 ` disabling sha1dc unaligned access, was " Jeff King
2019-03-11 10:40 ` Jeffrey Walton
2019-03-11 18:19 ` Jeff King
2019-03-11 11:58 ` Duy Nguyen
2019-03-11 18:15 ` Thomas Braun
2019-03-11 18:23 ` Jeff King
2019-03-12 7:27 ` Junio C Hamano
2019-03-12 10:51 ` Jeff King
2019-03-13 11:47 ` Thomas Braun
2019-03-13 15:39 ` Jeff King
2019-03-13 16:00 ` Ævar Arnfjörð Bjarmason
2019-03-12 8:53 ` Ævar Arnfjörð Bjarmason
2019-03-12 11:05 ` Jeff King
2019-03-12 12:09 ` Ævar Arnfjörð Bjarmason
2019-03-12 21:01 ` Jeff King
2019-03-12 21:06 ` [PATCH] Makefile: fix unaligned loads in sha1dc with UBSan Jeff King
2019-03-12 21:17 ` Ævar Arnfjörð Bjarmason
2019-03-12 21:19 ` Jeff King [this message]
2019-03-11 3:29 ` One failed self test on Fedora 29 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312211908.GA24509@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=noloader@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).