From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 185AB20248 for ; Sun, 10 Mar 2019 23:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbfCJX0l (ORCPT ); Sun, 10 Mar 2019 19:26:41 -0400 Received: from cloud.peff.net ([104.130.231.41]:45214 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727033AbfCJX0l (ORCPT ); Sun, 10 Mar 2019 19:26:41 -0400 Received: (qmail 11874 invoked by uid 109); 10 Mar 2019 23:26:41 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Sun, 10 Mar 2019 23:26:41 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18369 invoked by uid 111); 10 Mar 2019 23:27:00 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Sun, 10 Mar 2019 19:27:00 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Sun, 10 Mar 2019 19:26:39 -0400 Date: Sun, 10 Mar 2019 19:26:39 -0400 From: Jeff King To: Thomas Gummerer Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin , Paul-Sebastian Ungureanu , SZEDER =?utf-8?B?R8OhYm9y?= , Joel Teichroeb Subject: Re: [PATCH v13 12/27] stash: convert drop and clear to builtin Message-ID: <20190310232639.GA3059@sigill.intra.peff.net> References: <20190225231631.30507-1-t.gummerer@gmail.com> <20190225231631.30507-13-t.gummerer@gmail.com> <20190307191533.GA29221@sigill.intra.peff.net> <20190309183021.GE31533@hank.intra.tgummerer.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190309183021.GE31533@hank.intra.tgummerer.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Mar 09, 2019 at 06:30:21PM +0000, Thomas Gummerer wrote: > On 03/07, Jeff King wrote: > > On Mon, Feb 25, 2019 at 11:16:16PM +0000, Thomas Gummerer wrote: > > > > > +static int do_drop_stash(const char *prefix, struct stash_info *info, int quiet) > > > > This series hit next recently, so I started building it merged with my > > -Wunused-parameters series. This "prefix" parameter is not ever used. > > Skimming through the function, I don't see anything that _should_ be > > using it, so I think it's just cruft, and not indicative of a bug. > > Agreed, I think it's only cruft, and shouldn't be used anywhere in the > function. Below is a patch to remove the parameter. Thanks. I did something similar temporarily for my own tree, but I'll assume yours will go on top of the stash topic upstream. The patch below looks good (and matches what I did locally). > > The same is true of create_stash() elsewhere in the series. But there it > > might be worth keeping for consistency with the other top-level action > > functions. The other ones pass "prefix" to parse_options(), but > > create_stash() doesn't actually parse any options (and intentionally so, > > since even "--help" should be taken as part of the stash message). > > Agreed, I'd be happy to keep the parameter there. Looking at your > fork, you seem to have some WIP patches to introduce a UNUSED macro > for parameters like this, which I don't think I've seen on the list > yet (though I may have just missed them). > > I guess it's probably best for you to mark this parameter as UNUSED as > part of your series, but if you have a different preference on how to > handle it, let me know. Yep, that sounds good; I'll eventually mark this UNUSED when I send those patches. The "mark unused" ones haven't hit the list yet. I've been trickling the patches out, 10 or so at a time, but I'm still on the "drop ones that we can" patches, and haven't even gotten to the "mark ones we want to keep" patches. :) -Peff