From: Thomas Gummerer <firstname.lastname@example.org> To: Jonathan Chang <email@example.com> Cc: Christian Couder <firstname.lastname@example.org>, git <email@example.com> Subject: Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Date: Sun, 10 Mar 2019 17:59:24 +0000 [thread overview] Message-ID: <20190310175924.GF31533@hank.intra.tgummerer.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 03/10, Jonathan Chang wrote: > Hi, > > Thanks for the reviews. > > Here are the changes in the second version: > - bug fixes > - add preparatory patch > - seperate different files to different patch > - change to use test_line_count in a seperate patch > > Also I found that there is no such function as test_char_count, > is it worthwile to add such function? Here are some stat: > > `git grep 'test_line_count' | wc -l` = 626 > `git grep 'wc -l' | wc -l` = 294 > `git grep 'wc -c' | wc -l` = 68 I do think it would be helpful to introduce that helper, especially if it is useful in this patch series. There seem to be enough other places where it can be useful to make it worth adding the helper. > -- >8 -- > > This is a preparatory step prior to removing the pipes after git > commands, which discards git's exit code and may mask a crash. The commit message should also describe why we need this preparatory step. Maybe something like: To reduce the noise in when refactoring this pipeline in a subsequent commit fix the indentation. This has been wrong since the refactoring done in 1b5b2b641a ("t0000: modernise style", 2012-03-02), but carries no meaning. > Signed-off-by: Jonathan Chang <email@example.com> > Out of curiosity, how did you create the patch? 'git format-patch' would add a '---' line followed by the diffstat, where you would usually put the commentary that you put before the scissors line. It seems like 'git am' still handles this fine, which I didn't know, just something I noticed because I'm used to the other format. Since this patch series is now 5 patches, that commentary should go into a cover letter (see the --cover-letter option in format-patch), so the reviewers can read that first, and read the patches with that in mind, focusing on the patch only, and not additional commentary that applies to the whole series when reading the patch. > diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh > index b6566003dd..53821f5817 100755 > --- a/t/t0000-basic.sh > +++ b/t/t0000-basic.sh > @@ -1132,7 +1132,7 @@ test_expect_success 'git commit-tree records the correct parent in a commit' ' > > test_expect_success 'git commit-tree omits duplicated parent in a commit' ' > commit2=$(echo NO | git commit-tree $P -p $commit0 -p $commit0) && > - parent=$(git show --pretty=raw $commit2 | > + parent=$(git show --pretty=raw $commit2 | > sed -n -e "s/^parent //p" -e "/^author /q" | > sort -u) && > test "z$commit0" = "z$parent" && > -- > 2.21.0 >
next prev parent reply other threads:[~2019-03-10 17:59 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-09 15:45 [GSoC][PATCH] tests: avoid using pipes Jonathan Chang 2019-03-09 16:45 ` Thomas Gummerer 2019-03-10 8:07 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Jonathan Chang 2019-03-10 8:08 ` [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes Jonathan Chang 2019-03-10 8:09 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Jonathan Chang 2019-03-10 8:10 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: " Jonathan Chang 2019-03-10 8:11 ` [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l Jonathan Chang 2019-03-10 9:50 ` Eric Sunshine 2019-03-11 16:10 ` ttjtftx 2019-03-10 10:03 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Eric Sunshine [not found] ` <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com> 2019-03-11 15:54 ` Fwd: " ttjtftx 2019-03-10 10:13 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Eric Sunshine 2019-03-15 1:56 ` jonathan chang 2019-03-10 17:59 ` Thomas Gummerer [this message] 2019-03-15 1:55 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error jonathan chang 2019-03-15 12:48 ` Christian Couder 2019-03-10 6:05 ` [GSoC][PATCH] tests: avoid using pipes Christian Couder 2019-03-10 8:27 ` ttjtftx 2019-03-10 15:05 ` Christian Couder [not found] ` <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com> 2019-03-11 16:45 ` Fwd: " jonathan chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190310175924.GF31533@hank.intra.tgummerer.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).