From: Jonathan Chang <ttjtftx@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Jonathan Chang <ttjtftx@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Thomas Gummerer <t.gummerer@gmail.com>, git <git@vger.kernel.org>
Subject: [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes
Date: Sun, 10 Mar 2019 16:10:23 +0800 [thread overview]
Message-ID: <20190310081023.64186-1-ttjtftx@gmail.com> (raw)
In-Reply-To: <20190310080931.64134-1-ttjtftx@gmail.com>
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
index 7af3fbcc7b..05f443dcce 100755
--- a/t/t0022-crlf-rename.sh
+++ b/t/t0022-crlf-rename.sh
@@ -23,10 +23,10 @@ test_expect_success setup '
test_expect_success 'diff -M' '
- git diff-tree -M -r --name-status HEAD^ HEAD |
- sed -e "s/R[0-9]*/RNUM/" >actual &&
+ git diff-tree -M -r --name-status HEAD^ HEAD >actual &&
+ sed -e "s/R[0-9]*/RNUM/" actual >output &&
echo "RNUM sample elpmas" >expect &&
- test_cmp expect actual
+ test_cmp expect output
'
--
2.21.0
next prev parent reply other threads:[~2019-03-10 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 15:45 [GSoC][PATCH] tests: avoid using pipes Jonathan Chang
2019-03-09 16:45 ` Thomas Gummerer
2019-03-10 8:07 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Jonathan Chang
2019-03-10 8:08 ` [GSoC][PATCH v2 2/5] t0000-basic: avoid using pipes Jonathan Chang
2019-03-10 8:09 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Jonathan Chang
2019-03-10 8:10 ` Jonathan Chang [this message]
2019-03-10 8:11 ` [GSoC][PATCH v2 5/5] t0000-basic: use test_line_count instead of wc -l Jonathan Chang
2019-03-10 9:50 ` Eric Sunshine
2019-03-11 16:10 ` ttjtftx
2019-03-10 10:03 ` [GSoC][PATCH v2 4/5] t0022-crlf-rename: avoid using pipes Eric Sunshine
[not found] ` <CAOAu_YJKNjGd3mw7K17ySQJeF4XxC+V00FFEYA7o593riEGN1g@mail.gmail.com>
2019-03-11 15:54 ` Fwd: " ttjtftx
2019-03-10 10:13 ` [GSoC][PATCH v2 3/5] t0003-attributes: " Eric Sunshine
2019-03-15 1:56 ` jonathan chang
2019-03-10 17:59 ` [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error Thomas Gummerer
2019-03-15 1:55 ` jonathan chang
2019-03-15 12:48 ` Christian Couder
2019-03-10 6:05 ` [GSoC][PATCH] tests: avoid using pipes Christian Couder
2019-03-10 8:27 ` ttjtftx
2019-03-10 15:05 ` Christian Couder
[not found] ` <CAOAu_YL8heWLSznRV8pjLkRZBOEth_7CSmftupx+4+SSx5yztw@mail.gmail.com>
2019-03-11 16:45 ` Fwd: " jonathan chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190310081023.64186-1-ttjtftx@gmail.com \
--to=ttjtftx@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).