git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Fabio Aiuto <polinice83@libero.it>
Cc: git@vger.kernel.org
Subject: Re: Can't build first git commit
Date: Thu, 7 Mar 2019 14:41:47 -0500	[thread overview]
Message-ID: <20190307194146.GA2453@sigill.intra.peff.net> (raw)
In-Reply-To: <1551985495.1606.1.camel@libero.it>

[+cc git@vger; let's keep this on the list; I'm not sure there's a lot
 to be learned from fiddling with this old version, but if we're going
 to do it, let's at least record our attempts for posterity]

On Thu, Mar 07, 2019 at 08:04:55PM +0100, Fabio Aiuto wrote:

> I made a directory "trial" and inside it I ran init-db (that's the
> grand-father of git init) inside that directory. Then I created a file 
> this way:
> 
> echo 'helloooo!' >file.txt
> 
> then then executed update-cache file.txt (thinking that's the ancestor
> of git add), but that doesn't work and it returns with a segmentation
> fault, due to the nullity of the header. But in this first commit how
> do I add a file in the cache? What's the right way to build up a
> repository from scratch with commit e83c5163316f?

Hmm. I tried that, too, and got a segfault. Then I tried it again a few
minutes later, and it worked.

One thing that seems to provoke it consistently is having a zero-length
index file (because that causes mmap to return NULL, and the code does
not check for that case). Try this:

  # This works.
  init-db
  echo content >file
  update-cache file

  # This segfaults
  >.dircache/index
  update-cache file

  # And this works again
  rm .dircache/index
  update-cache file

I'm not sure why it would ever fail without that explicit empty-file
write. Perhaps there's some code path that writes out an empty index
file, and we inadvertently triggered it.

If you're going to play with such an antique commit, you have to expect
that things won't necessarily work, and be ready to poke around in the
debugger.

-Peff

  parent reply	other threads:[~2019-03-07 19:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 19:58 Can't build first git commit Fabio Aiuto
2019-03-04 20:10 ` Santiago Torres
2019-03-04 20:19   ` Fabio Aiuto
2019-03-04 20:22     ` Santiago Torres
2019-03-04 21:48     ` asymptosis
2019-03-04 22:25     ` Jonathan Nieder
2019-03-04 20:40 ` Jeff King
2019-03-05 18:42   ` Fabio Aiuto
2019-03-05 19:15   ` Jeff King
2019-03-06 19:58     ` Fabio Aiuto
2019-03-06 20:03       ` Jeff King
2019-03-06 20:19         ` Fabio Aiuto
2019-03-06 20:39           ` Santiago Torres
2019-03-06 21:54             ` Jeff King
2019-03-06 20:52         ` Fabio Aiuto
2019-03-06 21:57           ` Jeff King
     [not found]             ` <1551985495.1606.1.camel@libero.it>
2019-03-07 19:41               ` Jeff King [this message]
2019-03-07 20:07                 ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307194146.GA2453@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=polinice83@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).