mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "Jesper Rønn-Jensen" <>
Subject: Re: Error fetching submodule from submodule
Date: Thu, 7 Mar 2019 13:08:31 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Mar 07, 2019 at 12:07:21PM +0100, Jesper Rønn-Jensen wrote:

> Hi I think I may have found an error in the way git handles a
> submodule's submodule. Read further for the example (extracted from a
> real project).

First off, thank you for the example script. It made understanding
what's going on so much easier. :)

> * I have a main repository which has some submodules defined.
> * One of the submodules is a common submodule which is also included
> in one of the other submodules
> * When running `git fetch --recurse-submodules` I get an error.

I think the presence of common_submodule in the main repo is actually a
red herring. if you remove the last two lines of this stanza:

> git setup main_repos
> pushd main_repos
> git submodule add ../common_submodule
> git commit -m 'added submodule to main_repos'

the outcome is the same.

> # This line fails with error code 1 "Could not access submodule
> 'common_submodule'"
> git fetch --recurse-submodules

It looks like "fetch" is smart enough to initialize a submodule when
necessary, but not smart enough to do so recursively. If I replace that
line with:

  git submodule update --init --recursive

then it works as I'd expect. Likewise, cloning the repository with:

  git clone --recurse-submodules main_repos foo

does what you'd want.

After that, I think "git fetch --recurse-submodules" does what you want,
because the submodule repository is already initialized.

I'm not sure to what degree git-fetch intended to support initializing
submodules. But it certainly seems like a bug that it handles the top
layer but does not recurse (i.e., it should either handle all or none).

Hopefully the commands above at least give you a workaround.


  reply	other threads:[~2019-03-07 18:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 11:07 Error fetching submodule from submodule Jesper Rønn-Jensen
2019-03-07 18:08 ` Jeff King [this message]
2019-03-08  8:50   ` Jesper Rønn-Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).