From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org
Subject: Re: [PATCH] builtin/config.c: don't print a newline with --color
Date: Wed, 6 Mar 2019 15:42:36 -0800 [thread overview]
Message-ID: <20190306234236.GE27082@Taylors-MBP.hsd1.wa.comcast.net> (raw)
In-Reply-To: <xmqqva0xvp6b.fsf@gitster-ct.c.googlers.com>
On Tue, Mar 05, 2019 at 02:57:32PM +0900, Junio C Hamano wrote:
> Yup, that would be a very sensible first step, regardless of what
> the next step is.
>
> After that, choices are
>
> (1) we'd introduce new inconsistency among --type=<type> by
> matching what --type=color does to what --get-color does, to
> allow us to revert that documentation update, or
I suppose... though I think that if others agree, I'd rather update the
documentation instead of introduce some inconsistency.
Yes, there's an argument to be made that if we're encouraging users to
go from '--get-color' -> '--type=color', that the two should behave the
same, but I don't think the cost we pay for behavioral equivalence
between the two is worth inconsistency among '--type=color' and all the
rest.
> (2) we'd drop LF from all --type=<type>, that makes everything
> consistent and risk breaking a few existing scripts while doing
> so, and get yelled at by end users, or
As you indicate, I think that this option is one we should _not_ do. In
the interpolation example you shared earlier in the thread, script
writers most likely want and expect a trailing LF after each invocation
of 'git config'.
I'd argue that this case is more common than not wanting a LF when
interpolating with `--type=color`, so I agree it seems the tradeoff here
is not a good one.
> (3) we stop at this documentation update and do nothing else.
To restate my response to (1), I think that the documentation update in
isolation makes the most sense here. I, too, was surprised in the same
way that Peff was when we stumbled upon this, but I think that
ultimately the consistency is most favorable.
Thanks all for your discussion and feedback.
Thanks,
Taylor
next prev parent reply other threads:[~2019-03-06 23:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:40 [PATCH] builtin/config.c: don't print a newline with --color Taylor Blau
2019-03-02 12:34 ` Eric Sunshine
2019-03-02 20:25 ` Johannes Schindelin
2019-03-03 17:24 ` Jeff King
2019-03-05 15:59 ` Johannes Schindelin
2019-03-06 23:44 ` Taylor Blau
2019-03-03 1:18 ` Junio C Hamano
2019-03-03 17:42 ` Jeff King
2019-03-04 4:28 ` Junio C Hamano
2019-03-04 5:05 ` Junio C Hamano
2019-03-05 4:20 ` Jeff King
2019-03-05 5:57 ` Junio C Hamano
2019-03-06 23:42 ` Taylor Blau [this message]
2019-03-07 0:50 ` Junio C Hamano
2019-03-07 2:57 ` Jeff King
2019-03-06 23:52 ` [PATCH v2] Documentation/config: note trailing newline with --type=color Taylor Blau
2019-03-07 2:58 ` Jeff King
2019-03-07 3:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306234236.GE27082@Taylors-MBP.hsd1.wa.comcast.net \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).