From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id F0E2520248 for ; Tue, 5 Mar 2019 23:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfCEXLo (ORCPT ); Tue, 5 Mar 2019 18:11:44 -0500 Received: from cloud.peff.net ([104.130.231.41]:40122 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726217AbfCEXLo (ORCPT ); Tue, 5 Mar 2019 18:11:44 -0500 Received: (qmail 28107 invoked by uid 109); 5 Mar 2019 23:11:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 05 Mar 2019 23:11:44 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3675 invoked by uid 111); 5 Mar 2019 23:12:01 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Tue, 05 Mar 2019 18:12:01 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 05 Mar 2019 18:11:42 -0500 Date: Tue, 5 Mar 2019 18:11:42 -0500 From: Jeff King To: Junio C Hamano Cc: =?utf-8?Q?Jean-No=C3=ABl?= Avila , git@vger.kernel.org Subject: Re: [PATCH] Doc: fix misleading asciidoc formating Message-ID: <20190305231142.GA359@sigill.intra.peff.net> References: <20190305214423.27820-1-jn.avila@free.fr> <20190305223655.GA27535@sigill.intra.peff.net> <20190305230227.GA22901@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190305230227.GA22901@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Mar 05, 2019 at 06:02:27PM -0500, Jeff King wrote: > On Wed, Mar 06, 2019 at 07:54:20AM +0900, Junio C Hamano wrote: > > > Jeff King writes: > > > > > Did you notice this when building locally, or on the asciidoctor-built > > > pages at git-scm.com? > > > > Does git-scm.com even have this file rendered? I do not think we > > glob for technical/*.txt in any of our Makefiles; instead we have a > > list of ready-to-be-consumed TECH_DOCS listed explicitly. > > It is rendered, at https://git-scm.com/docs/directory-rename-detection. By the way, that rendering shows that the whole document could probably use a few tweaks to make its asciidoc formatting look good (in addition to the "x." thing that Jean-Noël fixed here, which can also be seen there). TBH, I still have mixed feelings on rendering these technical docs with asciidoc at all. It seems like few enough people bother to render them that bugs persist for a long time. It kind of seems like make-work getting them to format correctly. -Peff