From: Rohit Ashiwal <rohit.ashiwal265@gmail.com> To: gitster@pobox.com Cc: Johannes.Schindelin@gmx.de, christian.couder@gmail.com, git@vger.kernel.org, rohit.ashiwal265@gmail.com, t.gummerer@gmail.com Subject: Clearing logic Date: Sun, 3 Mar 2019 19:37:09 +0530 [thread overview] Message-ID: <20190303140709.5561-1-rohit.ashiwal265@gmail.com> (raw) In-Reply-To: <xmqqo96syte0.fsf@gitster-ct.c.googlers.com> On 2019-03-03 13:33 UTC Junio C Hamano <gitster@pobox.com> wrote: > test -s <path> makes sure <path> is file; if it is not a file, then > it won't yield true. > On 2019-03-03 13:20 UTC Rohit Ashiwal <rohit.ashiwal265@gmail.com> wrote: > > test_path_is_file "$1" && > > if ! test -s "$1" According to the conditional if the path is not a file then we will get the error "file does not exist" and then we will shortcircuit without checking the second conditional, on the other hand, if path is a file then we will again check if it has a size greater than zero, then error will be different (if any). Regards Rohit
next prev parent reply other threads:[~2019-03-03 14:07 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-03 12:28 [GSoC][PATCH 0/3] Use helper functions in test script Rohit Ashiwal 2019-03-03 12:28 ` [PATCH 1/3] test functions: Add new function `test_file_not_empty` Rohit Ashiwal 2019-03-03 13:20 ` Junio C Hamano 2019-03-03 13:29 ` Rohit Ashiwal 2019-03-03 13:33 ` none Junio C Hamano 2019-03-03 14:07 ` Rohit Ashiwal [this message] 2019-03-03 16:19 ` Clearing logic Thomas Gummerer 2019-03-03 12:28 ` [PATCH 2/3] t3600: refactor code according to contemporary guidelines Rohit Ashiwal 2019-03-03 13:30 ` Junio C Hamano 2019-03-03 14:13 ` t3600: refactor code according to comtemporary guidelines Rohit Ashiwal 2019-03-03 12:28 ` [PATCH 3/3] t3600: use helper functions from test-lib-functions Rohit Ashiwal 2019-03-03 13:32 ` Junio C Hamano 2019-03-03 23:37 ` [GSoC][PATCH v2 0/3] Use helper functions in test script Rohit Ashiwal 2019-03-03 23:37 ` [GSoC][PATCH v2 1/3] test functions: add function `test_file_not_empty` Rohit Ashiwal 2019-03-04 3:45 ` Junio C Hamano 2019-03-03 23:37 ` [GSoC][PATCH v2 2/3] t3600: restructure code according to contemporary guidelines Rohit Ashiwal 2019-03-04 4:17 ` Junio C Hamano 2019-03-03 23:37 ` [GSoC][PATCH v2 3/3] t3600: use helpers to replace test -d/f/e/s <path> Rohit Ashiwal 2019-03-04 12:07 ` [GSoC][PATCH v3 0/3] Use helper functions in test script Rohit Ashiwal 2019-03-04 12:07 ` [GSoC][PATCH v3 1/3] test functions: add function `test_file_not_empty` Rohit Ashiwal 2019-03-05 0:17 ` Eric Sunshine 2019-03-05 12:43 ` Junio C Hamano 2019-03-05 13:27 ` [GSoc][PATCH " Rohit Ashiwal 2019-03-04 12:08 ` [GSoC][PATCH v3 2/3] t3600: modernize style Rohit Ashiwal 2019-03-05 0:36 ` Eric Sunshine 2019-03-05 12:44 ` Junio C Hamano 2019-03-04 12:08 ` [GSoC][PATCH v3 3/3] t3600: use helpers to replace test -d/f/e/s <path> Rohit Ashiwal 2019-03-05 0:42 ` Eric Sunshine 2019-03-05 13:42 ` Rohit Ashiwal 2019-03-05 14:03 ` Eric Sunshine 2019-03-05 14:21 ` [GSoC][PATCH v2 " Rohit Ashiwal 2019-03-05 14:57 ` Eric Sunshine 2019-03-05 23:38 ` Rohit Ashiwal 2019-03-08 5:38 ` [GSoC][PATCH v2 3/3] t3600: use helpers to replace test -d/f/e/s <path> Junio C Hamano 2019-03-08 9:51 ` Eric Sunshine 2019-03-11 1:54 ` Junio C Hamano 2019-03-05 0:09 ` [GSoC][PATCH v3 0/3] Use helper functions in test script Eric Sunshine
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190303140709.5561-1-rohit.ashiwal265@gmail.com \ --to=rohit.ashiwal265@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=t.gummerer@gmail.com \ --subject='Re: Clearing logic' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).