From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Rohit Ashiwal via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Rohit Ashiwal <rohit.ashiwal265@gmail.com>,
Jeff King <peff@peff.net>, Matthieu Moy <git@matthieu-moy.fr>
Subject: Re: Do test-path_is_{file,dir,exists} make sense anymore with -x?
Date: Tue, 26 Feb 2019 18:04:00 +0100 [thread overview]
Message-ID: <20190226170400.GC19739@szeder.dev> (raw)
In-Reply-To: <87sgwav8cp.fsf@evledraar.gmail.com>
On Tue, Feb 26, 2019 at 05:10:30PM +0100, Ævar Arnfjörð Bjarmason wrote:
> However. I wonder in general if we've re-visited the utility of these
> wrappers and maybe other similar wrappers after -x was added.
> But 4 years after this was added in a136f6d8ff ("test-lib.sh: support -x
> option for shell-tracing", 2014-10-10) we got -x, and then with "-i -v -x":
'-x' tracing doesn't work in all test scripts, unless it is run with a
Bash version already supporting BASH_XTRACEFD, i.e. v4.1 or later.
Notably the default Bash shipped in macOS is somewhere around v3.2.
> And at least to me whenever I have a test failure the first thing I do
> is try with -x (if I wasn't already using it). Under that the wrapper
> output is more verbose and no more helpful. It's immediately clear
> what's going on with:
>
> + test -f doesnotexist
> error: last command exited with $?=1
>
> Whereas:
>
> + test -f doesnotexist
> + echo File doesnotexist doesn't exist.
> File doesnotexist doesn't exist.
> + false
> error: last command exited with $?=1
>
> Gives me the same thing, but I have to read 5 lines instead of 2 that
> ultimately don't tell me any more (and a bit of "huh, 'false' returned
> 1? Of course! Oh! It's faking things up and it's the 'echo' that
> matters...").
I didn't find this to be an issue, but because of functions like
'test_seq' and 'test_must_fail' I've thought about suppressing '-x'
output for test helpers (haven't actually done anything about it,
though).
> Looking over test-lib-functions.sh this patch would do it. I couldn't
> spot any other functions redundant to -x:
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 80402a428f..b3a95b4968 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -555,33 +555,6 @@ test_external_without_stderr () {
> fi
> }
>
> -# debugging-friendly alternatives to "test [-f|-d|-e]"
> -# The commands test the existence or non-existence of $1. $2 can be
> -# given to provide a more precise diagnosis.
Note the second parameter; though, of course, you could argue that we
use it so rarely that it wouldn't really be missed.
> -test_path_is_file () {
> - if ! test -f "$1"
> - then
> - echo "File $1 doesn't exist. $2"
> - false
> - fi
> -}
> -
> -test_path_is_dir () {
> - if ! test -d "$1"
> - then
> - echo "Directory $1 doesn't exist. $2"
> - false
> - fi
> -}
> -
> -test_path_exists () {
> - if ! test -e "$1"
> - then
> - echo "Path $1 doesn't exist. $2"
> - false
> - fi
> -}
> -
> # Check if the directory exists and is empty as expected, barf otherwise.
> test_dir_is_empty () {
> test_path_is_dir "$1" &&
> @@ -593,19 +566,6 @@ test_dir_is_empty () {
> fi
> }
>
> -test_path_is_missing () {
> - if test -e "$1"
> - then
> - echo "Path exists:"
> - ls -ld "$1"
This 'ls' command gives a bit of additional info.
> - if test $# -ge 1
> - then
> - echo "$*"
> - fi
> - false
> - fi
> -}
> -
> # test_line_count checks that a file has the number of lines it
> # ought to. For example:
> #
> @@ -849,6 +809,9 @@ verbose () {
> # otherwise.
>
> test_must_be_empty () {
> + # We don't want to remove this as noted in ec10b018e7 ("tests:
> + # use 'test_must_be_empty' instead of '! test -s'",
> + # 2018-08-19)
Indeed.
> test_path_is_file "$1" &&
This still uses 'test_path_is_file'.
> if test -s "$1"
> then
next prev parent reply other threads:[~2019-02-26 17:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 13:42 [PATCH 0/1] [GSoC][PATCH] tests: replace test -(d|f) with test_path_is_(dir|file) Rohit Ashiwal via GitGitGadget
2019-02-26 13:42 ` [PATCH 1/1] tests: replace `test -(d|f)` " Rohit Ashiwal via GitGitGadget
2019-02-26 14:04 ` Duy Nguyen
2019-02-26 16:10 ` Do test-path_is_{file,dir,exists} make sense anymore with -x? Ævar Arnfjörð Bjarmason
2019-02-26 17:04 ` SZEDER Gábor [this message]
2019-02-26 17:43 ` Jeff King
2019-02-26 19:39 ` SZEDER Gábor
2019-02-26 21:01 ` Jeff King
2019-03-03 16:04 ` SZEDER Gábor
2019-03-05 4:55 ` Jeff King
2019-03-04 14:36 ` SZEDER Gábor
2019-03-05 4:58 ` Jeff King
2019-02-26 17:48 ` Matthieu Moy
2019-02-26 18:24 ` Jeff King
2019-02-26 17:35 ` Jeff King
2019-02-26 19:58 ` Johannes Schindelin
2019-02-26 21:02 ` Jeff King
2019-02-27 10:01 ` Duy Nguyen
2019-03-01 2:52 ` Junio C Hamano
2019-02-26 16:01 ` [PATCH 1/1] tests: replace `test -(d|f)` with test_path_is_(dir|file) Johannes Schindelin
2019-02-26 16:30 ` Martin Ågren
2019-02-26 18:29 ` Rohit Ashiwal
2019-02-26 19:52 ` Johannes Schindelin
2019-02-26 20:01 ` Rohit Ashiwal
2019-02-27 5:49 ` Martin Ågren
2019-02-26 14:26 ` [PATCH v2 0/1] [GSoC][PATCH] t3600: use test_path_is_dir and test_path_is_file Rohit Ashiwal via GitGitGadget
2019-02-26 14:26 ` [PATCH v2 1/1] " Rohit Ashiwal via GitGitGadget
2019-02-26 16:37 ` SZEDER Gábor
2019-02-26 18:40 ` Rohit Ashiwal
2019-02-26 20:02 ` Johannes Schindelin
2019-02-26 20:05 ` Rohit Ashiwal
2019-02-26 22:48 ` [PATCH v3 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-26 22:48 ` [PATCH v3 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-27 10:12 ` Duy Nguyen
2019-02-28 10:26 ` [PATCH v4 0/1] [GSoC][PATCH] t3600: use test_path_is_* helper functions Rohit Ashiwal via GitGitGadget
2019-02-28 10:26 ` [PATCH v4 1/1] t3600: use test_path_is_* functions Rohit Ashiwal via GitGitGadget
2019-02-28 19:02 ` [GSoC] acknowledging mistakes Rohit Ashiwal
2019-03-01 2:51 ` Junio C Hamano
2019-03-01 13:13 ` Feeling confused a little bit Rohit Ashiwal
2019-03-02 4:24 ` Rafael Ascensão
2019-03-02 14:46 ` Thomas Gummerer
2019-03-02 16:21 ` [GSoC] Thanking Rohit Ashiwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226170400.GC19739@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=rohit.ashiwal265@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).