From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] asciidoctor-extensions: fix spurious space after linkgit
Date: Tue, 26 Feb 2019 03:22:01 +0000 [thread overview]
Message-ID: <20190226032201.GD601925@genre.crustytoothpaste.net> (raw)
In-Reply-To: <cover.1551123979.git.martin.agren@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Mon, Feb 25, 2019 at 09:02:37PM +0100, Martin Ågren wrote:
> Patch 3/3 gets rid of a spurious space which shows up immediately after
> Asciidoctor has expanded linkgit:foo[bar] if the macro is followed by
> punctuation such as a comma, period or closing parenthesis.
>
> Patch 2/3 adds a missing dependency to the makefile, so that the docs
> will actually be rebuilt with that final patch. Patch 1/3 isn't needed
> for this series, but could help someone in the future, similar to how
> already having patch 2/3 would have helped me...
>
> Martin Ågren (3):
> Documentation/Makefile: add missing xsl dependencies for manpages
> Documentation/Makefile: add missing dependency on
> asciidoctor-extensions
> asciidoctor-extensions: fix spurious space after linkgit
>
> Documentation/Makefile | 4 ++--
> Documentation/asciidoctor-extensions.rb | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks for putting this series together. I would suggest an update to
the commit message in 1/3 explaining the edge case that Eric Sunshine
mentioned, but otherwise, I think this looks good.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-02-26 3:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 20:02 [PATCH 0/3] asciidoctor-extensions: fix spurious space after linkgit Martin Ågren
2019-02-25 20:02 ` [PATCH 1/3] Documentation/Makefile: add missing xsl dependencies for manpages Martin Ågren
2019-02-25 20:08 ` Eric Sunshine
2019-02-25 20:28 ` Martin Ågren
2019-02-25 21:00 ` Eric Sunshine
2019-02-26 5:59 ` Martin Ågren
2019-02-26 12:47 ` Eric Sunshine
2019-02-27 18:19 ` Martin Ågren
2019-02-25 20:02 ` [PATCH 2/3] Documentation/Makefile: add missing dependency on asciidoctor-extensions Martin Ågren
2019-02-25 20:02 ` [PATCH 3/3] asciidoctor-extensions: fix spurious space after linkgit Martin Ågren
2019-02-26 3:20 ` brian m. carlson
2019-02-26 3:22 ` brian m. carlson [this message]
2019-02-26 6:03 ` [PATCH 0/3] " Martin Ågren
2019-02-27 18:17 ` [PATCH v2 " Martin Ågren
2019-02-27 18:17 ` [PATCH v2 1/3] Documentation/Makefile: add missing xsl dependencies for manpages Martin Ågren
2019-02-27 18:17 ` [PATCH v2 2/3] Documentation/Makefile: add missing dependency on asciidoctor-extensions Martin Ågren
2019-02-27 18:17 ` [PATCH v2 3/3] asciidoctor-extensions: fix spurious space after linkgit Martin Ågren
2019-02-28 23:50 ` [PATCH v2 0/3] " brian m. carlson
2019-03-03 1:25 ` Junio C Hamano
2019-03-10 15:14 ` [PATCH 0/2] fix spurious space after linkgit, now in *.html Martin Ågren
2019-03-10 15:14 ` [PATCH 1/2] Documentation/Makefile: add missing dependencies on asciidoctor-extensions Martin Ågren
2019-03-10 15:14 ` [PATCH 2/2] asciidoctor-extensions: fix spurious space after linkgit in *.html Martin Ågren
2019-03-11 2:59 ` [PATCH 0/2] fix spurious space after linkgit, now " Jeff King
2019-03-11 5:47 ` Martin Ågren
2019-03-11 3:02 ` Junio C Hamano
2019-03-11 5:40 ` Martin Ågren
2019-03-11 9:24 ` Junio C Hamano
2019-03-11 9:26 ` [PATCH v3 1/3] Documentation/Makefile: add missing xsl dependencies for manpages Junio C Hamano
2019-03-11 9:26 ` [PATCH v3 2/3] Documentation/Makefile: add missing dependency on asciidoctor-extensions Junio C Hamano
2019-03-11 9:26 ` [PATCH v3 3/3] asciidoctor-extensions: fix spurious space after linkgit Junio C Hamano
2019-03-11 11:02 ` [PATCH 0/2] fix spurious space after linkgit, now in *.html Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226032201.GD601925@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).