From: Max Kirillov <max@max630.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Max Kirillov <max@max630.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
git@vger.kernel.org
Subject: Re: [RFC PATCH] pack-refs: fail on falsely sorted packed-refs
Date: Sat, 23 Feb 2019 09:09:14 +0200 [thread overview]
Message-ID: <20190223070914.GC2354@jessie.local> (raw)
In-Reply-To: <87lg2kj91a.fsf@evledraar.gmail.com>
On Wed, Feb 13, 2019 at 11:08:01AM +0100, Ævar Arnfjörð Bjarmason wrote:
> You have an extra two whitespaces after "&&" there.
Thanks, will check it.
>> + git commit --allow-empty -m commit &&
> Looks like just "test_commit A" would do here.
About this I'm not sure. AFAIK test_commit does lots of stuff,
so can it be considered "just" compared to "commit
--allow-empty" or the opposite? I could replace it with
test_commit for uniformity reason though.
> We can fail in these sorts of loops. There's a few ways to deal with
> that. Doing it like this with "break" will still silently hide errors:
Thanks, this was pointed point
>> + printf "$head_object refs/heads/b00\\n" >>.git/packed-refs &&
>
> Looks like just "echo" here would be simpler since we only use printf to
> add a newline.
Could it happen so that "echo" adds '\r\n' at Windows? I
could use echo.
> Instead of "! git ..." use "test_must_fail git ...". See t/README. This
> will hide e.g. segfaults.
Thanks, this was pointed point
> Also, perhaps:
>
> test_must_fail git ... 2>stderr &&
> grep "broken sorting in packed-refs" stderr
>
> Would make this more obvious/self-documenting so we know we failed due
> to that issue in particular.
Thanks, will change it
prev parent reply other threads:[~2019-02-23 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 23:13 [RFC PATCH] pack-refs: fail on falsely sorted packed-refs Max Kirillov
2019-01-30 23:31 ` Eric Sunshine
2019-01-31 8:21 ` Max Kirillov
2019-02-08 21:22 ` [PATCH v2] " Max Kirillov
2019-02-08 21:40 ` Eric Sunshine
2019-02-13 4:24 ` Max Kirillov
[not found] ` <CAMy9T_EX_L80-V4zD626nFCxw6qa90+pZwcbd6wHw9ZHcj2rNA@mail.gmail.com>
2019-02-13 4:23 ` Max Kirillov
2019-02-13 10:08 ` [RFC PATCH] " Ævar Arnfjörð Bjarmason
2019-02-13 10:56 ` SZEDER Gábor
2019-02-23 7:10 ` Max Kirillov
2019-02-14 6:06 ` Jeff King
2019-02-23 7:09 ` Max Kirillov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223070914.GC2354@jessie.local \
--to=max@max630.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).