From: Josh Steadmon <steadmon@google.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Sebastian Staudt" <koraktor@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 0/2] BSD portability fixes for 2.21.0-rc2
Date: Thu, 21 Feb 2019 16:37:06 -0800 [thread overview]
Message-ID: <20190222003706.GA159944@google.com> (raw)
In-Reply-To: <20190221192849.6581-1-avarab@gmail.com>
On 2019.02.21 20:28, Ævar Arnfjörð Bjarmason wrote:
> Last-minute fixes for two issues new in 2.21, not in 2.20.
>
> This fixes a NetBSD portability issue I noted in
> https://public-inbox.org/git/87d0nm5x1d.fsf@evledraar.gmail.com/
> thanks to SZEDER for the help.
>
> Then there's a another fix for a test breaking on OpenBSD due to
> recently merged unportable regex syntax.
>
> Ævar Arnfjörð Bjarmason (2):
> tests: fix unportable "\?" and "\+" regex syntax
> commit-graph tests: fix cryptic unportable "dd" invocation
>
> t/t5318-commit-graph.sh | 3 ++-
> t/t6120-describe.sh | 8 ++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> --
> 2.21.0.rc0.258.g878e2cd30e
>
These both look good to me. Thanks!
Reviewed-by: Josh Steadmon <steadmon@google.com>
next prev parent reply other threads:[~2019-02-22 0:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 23:29 [ANNOUNCE] Git v2.21.0-rc2 Junio C Hamano
2019-02-20 0:43 ` Randall S. Becker
2019-02-20 19:41 ` Junio C Hamano
2019-02-20 20:46 ` Johannes Schindelin
2019-02-21 13:10 ` Duy Nguyen
2019-02-21 23:55 ` brian m. carlson
2019-02-22 9:13 ` Duy Nguyen
2019-02-21 15:54 ` Randall S. Becker
2019-02-21 20:04 ` Junio C Hamano
2019-02-21 21:06 ` SZEDER Gábor
2019-02-21 21:30 ` Randall S. Becker
2019-02-21 19:59 ` Randall S. Becker
2019-02-21 10:46 ` Git for Windows v2.21.0-rc2, was " Johannes Schindelin
2019-02-21 19:28 ` [PATCH 0/2] BSD portability fixes for 2.21.0-rc2 Ævar Arnfjörð Bjarmason
2019-02-22 0:37 ` Josh Steadmon [this message]
2019-02-21 19:28 ` [PATCH 1/2] tests: fix unportable "\?" and "\+" regex syntax Ævar Arnfjörð Bjarmason
2019-02-22 5:00 ` Junio C Hamano
2019-02-21 19:28 ` [PATCH 2/2] commit-graph tests: fix cryptic unportable "dd" invocation Ævar Arnfjörð Bjarmason
2019-02-21 20:43 ` SZEDER Gábor
2019-02-21 22:26 ` Ævar Arnfjörð Bjarmason
2019-02-22 10:50 ` SZEDER Gábor
2019-02-22 14:34 ` Ævar Arnfjörð Bjarmason
2019-02-22 18:30 ` Junio C Hamano
2019-02-22 18:35 ` Todd Zullinger
2019-02-22 19:23 ` [PATCH v3] commit-graph tests: fix " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222003706.GA159944@google.com \
--to=steadmon@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=koraktor@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).