On Tue, Feb 12, 2019 at 11:59:27AM +0100, Ævar Arnfjörð Bjarmason wrote: > The gitweb code doesn't load Git.pm now, but does anyone know a reason > for why we'd avoid any perl/* dependency in the gitweb code? If not the > regex here & in gitweb could be factored into e.g. a tiny Git::OID > library which would either just expose a $GIT::OID_REGEX, or something > like the sort of interface (might not be worth it) that I suggested in > my feedback to 31/31. I think one potential issue here is that some distributors bundle the Perl modules with git send-email and not gitweb, and they're packaged independently. I'm not opposed to seeing a patch to do that, but it probably belongs in its own series. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204