list mirror (unofficial, one of many)
 help / color / Atom feed
From: Jeff King <>
To: Todd Zullinger <>
Cc:, Jonathan Tan <>,
	Junio C Hamano <>
Subject: Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache
Date: Thu, 14 Feb 2019 01:52:27 -0500
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Feb 14, 2019 at 01:35:13AM -0500, Todd Zullinger wrote:

> 07c3c2aa16 ("tests: define GIT_TEST_SIDEBAND_ALL", 2019-01-16) added
> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings
> from Apache when the variable is unset, as we do for GIT_VALGRIND* and
> GIT_TRACE, from f628825481 ("t/lib-httpd: handle running under
> --valgrind", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
> Apache", 2015-03-13), respectively.
> Signed-off-by: Todd Zullinger <>
> ---
> I missed this with rc0, but poking through build logs I noticed a number
> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'
> warnings.
> I think exporting this in like we do for GIT_VALGRIND* and
> GIT_TRACE is the way to go, as opposed to in, as we do for
> things like GNUPGHOME.  But I could easily be wrong about that.

Yeah, I think this is the right place to put it (and this approach is
the right thing to do).

> diff --git a/t/ b/t/
> index 216281eabc..0dfb48c2f6 100644
> --- a/t/
> +++ b/t/
>  # hack to suppress apache PassEnv warnings

I applaud your attempt to alphabetize, but the existing list is already
out of order. ;) I don't think it really matters much either way,


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  6:35 Todd Zullinger
2019-02-14  6:52 ` Jeff King [this message]
2019-02-14  7:00   ` Todd Zullinger
2019-02-14 20:17 ` Jonathan Tan
2019-02-14 20:47   ` Todd Zullinger
2019-02-14 21:20     ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone