From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/10] dropping more unused function parameters
Date: Thu, 14 Feb 2019 00:47:37 -0500 [thread overview]
Message-ID: <20190214054736.GA20091@sigill.intra.peff.net> (raw)
Here are ten more patches from my exploration of -Wunused-parameters.
Most of these are quite old and not urgent, but things seem relatively
quiet now, and they all merge cleanly with "pu".
In a sense they should all be trivial to review, as they only remove
unused parameters. But the thing to consider is whether that parameter's
lack of use is actually a bug, or if it's simply cruft (and I argue in
each case in favor of cruft).
[01/10]: diff: drop options parameter from diffcore_fix_diff_index()
[02/10]: diff: drop unused color reset parameters
[03/10]: diff: drop unused emit data parameter from sane_truncate_line()
[04/10]: diff: drop complete_rewrite parameter from run_external_diff()
[05/10]: merge-recursive: drop several unused parameters
[06/10]: pack-objects: drop unused parameter from oe_map_new_pack()
[07/10]: files-backend: drop refs parameter from split_symref_update()
[08/10]: ref-filter: drop unused buf/sz pairs
[09/10]: ref-filter: drop unused "obj" parameters
[10/10]: ref-filter: drop unused "sz" parameters
diff-lib.c | 2 +-
diff.c | 31 ++++++++++++-------------------
diff.h | 2 +-
merge-recursive.c | 19 +++++++------------
pack-objects.c | 3 +--
pack-objects.h | 6 +++---
ref-filter.c | 36 ++++++++++++++++++------------------
refs/files-backend.c | 5 ++---
8 files changed, 45 insertions(+), 59 deletions(-)
-Peff
next reply other threads:[~2019-02-14 5:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 5:47 Jeff King [this message]
2019-02-14 5:48 ` [PATCH 01/10] diff: drop options parameter from diffcore_fix_diff_index() Jeff King
2019-02-14 5:48 ` [PATCH 02/10] diff: drop unused color reset parameters Jeff King
2019-02-14 5:48 ` [PATCH 03/10] diff: drop unused emit data parameter from sane_truncate_line() Jeff King
2019-02-14 5:49 ` [PATCH 04/10] diff: drop complete_rewrite parameter from run_external_diff() Jeff King
2019-02-14 5:50 ` [PATCH 05/10] merge-recursive: drop several unused parameters Jeff King
2019-02-14 5:50 ` [PATCH 06/10] pack-objects: drop unused parameter from oe_map_new_pack() Jeff King
2019-02-14 5:50 ` [PATCH 07/10] files-backend: drop refs parameter from split_symref_update() Jeff King
2019-02-14 5:50 ` [PATCH 08/10] ref-filter: drop unused buf/sz pairs Jeff King
2019-02-14 5:50 ` [PATCH 09/10] ref-filter: drop unused "obj" parameters Jeff King
2019-02-14 5:51 ` [PATCH 10/10] ref-filter: drop unused "sz" parameters Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214054736.GA20091@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).