* git can't add ignored file if GIT_ICASE_PATHSPECS=1
@ 2019-02-12 17:19 Giuseppe Crino'
2019-02-12 17:27 ` Giuseppe Crino'
0 siblings, 1 reply; 2+ messages in thread
From: Giuseppe Crino' @ 2019-02-12 17:19 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
To reproduce, apply the attached patch and run at the project root
cd t && ./t3700-add.sh --verbose-only=13 --debug --immediate
Relevant part of the output is
expecting success:
export GIT_ICASE_PATHSPECS=1 &&
touch a.if &&
test_must_fail git add a.?? &&
! (git ls-files | grep "\\.ig") &&
(git ls-files | grep a.if)
fatal: pathspec 'a.ig' did not match any files
not ok 13 - error out when attempting to add ignored ones but add others
#
# export GIT_ICASE_PATHSPECS=1 &&
# touch a.if &&
# test_must_fail git add a.?? &&
# ! (git ls-files | grep "\\.ig") &&
# (git ls-files | grep a.if)
As I understand this, it's a bug.
Giuseppe
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 456 bytes --]
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 37729ba258..62557e6a3d 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -91,6 +91,7 @@ test_expect_success 'error out when attempting to add ignored ones without -f' '
'
test_expect_success 'error out when attempting to add ignored ones but add others' '
+ export GIT_ICASE_PATHSPECS=1 &&
touch a.if &&
test_must_fail git add a.?? &&
! (git ls-files | grep "\\.ig") &&
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: git can't add ignored file if GIT_ICASE_PATHSPECS=1
2019-02-12 17:19 git can't add ignored file if GIT_ICASE_PATHSPECS=1 Giuseppe Crino'
@ 2019-02-12 17:27 ` Giuseppe Crino'
0 siblings, 0 replies; 2+ messages in thread
From: Giuseppe Crino' @ 2019-02-12 17:27 UTC (permalink / raw)
To: git
I forgot to mention that the issue is present both in maint and in the master branch.
On Tue, Feb 12, 2019 at 06:19:52PM +0100, Giuseppe Crino' wrote:
> To reproduce, apply the attached patch and run at the project root
>
> cd t && ./t3700-add.sh --verbose-only=13 --debug --immediate
>
> Relevant part of the output is
>
> expecting success:
> export GIT_ICASE_PATHSPECS=1 &&
> touch a.if &&
> test_must_fail git add a.?? &&
> ! (git ls-files | grep "\\.ig") &&
> (git ls-files | grep a.if)
>
> fatal: pathspec 'a.ig' did not match any files
> not ok 13 - error out when attempting to add ignored ones but add others
> #
> # export GIT_ICASE_PATHSPECS=1 &&
> # touch a.if &&
> # test_must_fail git add a.?? &&
> # ! (git ls-files | grep "\\.ig") &&
> # (git ls-files | grep a.if)
>
> As I understand this, it's a bug.
>
> Giuseppe
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 37729ba258..62557e6a3d 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -91,6 +91,7 @@ test_expect_success 'error out when attempting to add ignored ones without -f' '
> '
>
> test_expect_success 'error out when attempting to add ignored ones but add others' '
> + export GIT_ICASE_PATHSPECS=1 &&
> touch a.if &&
> test_must_fail git add a.?? &&
> ! (git ls-files | grep "\\.ig") &&
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 17:19 git can't add ignored file if GIT_ICASE_PATHSPECS=1 Giuseppe Crino'
2019-02-12 17:27 ` Giuseppe Crino'
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).