From: Todd Zullinger <tmz@pobox.com> To: "SZEDER Gábor" <szeder.dev@gmail.com> Cc: git@vger.kernel.org, Henning Schild <henning.schild@siemens.com>, Junio C Hamano <gitster@pobox.com> Subject: Re: [PATCH 1/2] t/lib-gpg: quote path to ${GNUPGHOME}/trustlist.txt Date: Fri, 8 Feb 2019 15:25:05 -0500 Message-ID: <20190208202505.GE30548@zaya.teonanacatl.net> (raw) In-Reply-To: <20190208201105.GA10587@szeder.dev> SZEDER Gábor wrote: > On Thu, Feb 07, 2019 at 10:17:45PM -0500, Todd Zullinger wrote: >> When gpgsm is installed, lib-gpg.sh attempts to update trustlist.txt to >> relax the checking of some root certificate requirements. The path to >> "${GNUPGHOME}" contains spaces which cause an "ambiguous redirect" >> warning when bash is used to run the tests: > > s/error/warning/ Did you mean s/warning/error/ so the sentence reads: The path to "${GNUPGHOME}" contains spaces which cause an "ambiguous redirect" error when bash is used to run the tests ? Is it worth a resend before Junio queues it? >> $ bash t7030-verify-tag.sh >> /git/t/lib-gpg.sh: line 66: ${GNUPGHOME}/trustlist.txt: ambiguous redirect >> ok 1 - create signed tags >> ok 2 # skip create signed tags x509 (missing GPGSM) >> ... >> >> No warning is issued when using bash called as /bin/sh, dash, or mksh. > > Likewise. > > POSIX says that no field splitting should be performed on the result > of a parameter expansion that is used as the target of a redirection, > but Bash doesn't conform in this respect (unless in POSIX mode). I wish I'd remembered reading your detailed explanation of this¹ when I was testing and writing the commit message. :) ¹ https://public-inbox.org/git/20180926121107.GH27036@localhost/ -- Todd
next prev parent reply other threads:[~2019-02-08 20:31 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 3:17 [PATCH 0/2] t/lib-gpg: a gpgsm fix, a minor improvement, and a question Todd Zullinger 2019-02-08 3:17 ` [PATCH 1/2] t/lib-gpg: quote path to ${GNUPGHOME}/trustlist.txt Todd Zullinger 2019-02-08 20:11 ` SZEDER Gábor 2019-02-08 20:25 ` Todd Zullinger [this message] 2019-02-08 20:35 ` SZEDER Gábor 2019-02-08 3:17 ` [PATCH 2/2] t/lib-gpg: drop redundant killing of gpg-agent Todd Zullinger 2019-02-08 8:33 ` [PATCH 0/2] t/lib-gpg: a gpgsm fix, a minor improvement, and a question Henning Schild 2019-02-08 18:04 ` Junio C Hamano 2019-02-09 14:06 ` SZEDER Gábor 2019-02-09 23:05 ` Todd Zullinger 2019-02-11 19:51 ` SZEDER Gábor 2019-02-14 6:32 ` Todd Zullinger 2019-02-12 0:44 ` Jeff King 2019-02-12 2:38 ` Junio C Hamano 2019-02-12 2:45 ` SZEDER Gábor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190208202505.GE30548@zaya.teonanacatl.net \ --to=tmz@pobox.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=henning.schild@siemens.com \ --cc=szeder.dev@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git