From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] add_to_index(): convert forgotten HASH_RENORMALIZE check
Date: Thu, 7 Feb 2019 16:00:09 -0500 [thread overview]
Message-ID: <20190207210009.GA30825@sigill.intra.peff.net> (raw)
In-Reply-To: <20190207041802.ai25fc64sqfg2h66@tb-raspi4>
On Thu, Feb 07, 2019 at 04:18:02AM +0000, Torsten Bögershausen wrote:
> And trying to answer an older question:
>
> >>>The reason appears to be wrong bit mask usage
> >>>#define ADD_CACHE_IGNORE_ERRORS 4
> >>>and
> >>>#define HASH_RENORMALIZE 4
>
> What if we had renamed "flags" like this ?
> [...]
> -int add_to_index(struct index_state *istate, const char *path, struct stat *st, int flags)
> +int add_to_index(struct index_state *istate, const char *path, struct stat *st, int add_cache_flags)
Yes, changing the name of the variable in the original patch would have
caught this case. I don't know if it is worth doing now or not (the code
as it is now seems pretty clear to me, but of course I've looked at it a
lot lately).
-Peff
next prev parent reply other threads:[~2019-02-07 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:25 t0025 flakey? Johannes Schindelin
2019-02-06 10:42 ` SZEDER Gábor
2019-02-06 13:52 ` Johannes Schindelin
2019-02-06 17:15 ` Torsten Bögershausen
2019-02-06 17:39 ` SZEDER Gábor
2019-02-06 18:00 ` Randall S. Becker
2019-02-07 16:58 ` Randall S. Becker
2019-02-07 17:39 ` Junio C Hamano
2019-02-07 23:57 ` SZEDER Gábor
2019-02-08 10:21 ` Randall S. Becker
2019-02-07 2:00 ` [PATCH] add_to_index(): convert forgotten HASH_RENORMALIZE check Jeff King
2019-02-07 4:18 ` Torsten Bögershausen
2019-02-07 21:00 ` Jeff King [this message]
2019-02-07 13:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207210009.GA30825@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).