git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet
Date: Mon, 4 Feb 2019 20:38:23 +0100	[thread overview]
Message-ID: <20190204193823.GA4511@szeder.dev> (raw)
In-Reply-To: <xmqqk1ifv296.fsf@gitster-ct.c.googlers.com>

On Mon, Feb 04, 2019 at 10:26:29AM -0800, Junio C Hamano wrote:
> SZEDER Gábor <szeder.dev@gmail.com> writes:
> 
> >   - This '--quiet' flag apparently broke overnight, resulting in
> >     errored builds:
> > ...
> >     I belive that this breakage will be noticed and fixed soon-ish, so
> >     we could probably just wait a bit for this issue to solve itself,
> 
> Yuck.  Well, an external influence that can break the automated
> build job overnight should be capable of fixing it overnight ;-)

> If this is truly urgent, I could merge this to 'maint' and merge the
> result upwards to 'pu' and it would hide the issue on my four
> integration branches.  But one thing that makes me wonder is if we
> can (or want to) do anything to help other people who test build
> with pull requests.  I guess they need to rebase on top of whatever
> commit that has this fix?  That sounds more like a tail wagging a
> dog, though.  I dunno.

Contributors don't have to rebase to make their PR builds work.  When
Travis CI builds a PR, it doesn't build the branch on its own, but the
merge of that branch into 'master' (or whatever the default branch is
called), assuming can be it merged cleanly.  So as soon as this fix
lands in master, the PR builds should be fine.  I suppose.

However, they will need to rebase their WIP/not PR-ed/not upstreamable
branches on top of this fix if they want to run Travis CI builds in
their own forks.

Unless, of course, the external influence does manage to fix itself
overnight :)  Under Dscho's bugreport it looks like they already
merged a one-liner fix, but how long will it take to tickle down to
Travis CI, I have no idea.


  reply	other threads:[~2019-02-04 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 16:34 [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet SZEDER Gábor
2019-02-04  9:49 ` Johannes Schindelin
2019-02-04 19:38   ` SZEDER Gábor
2019-02-05 11:31     ` Johannes Schindelin
2019-02-04 18:26 ` Junio C Hamano
2019-02-04 19:38   ` SZEDER Gábor [this message]
2019-02-05 11:41     ` Johannes Schindelin
2019-02-05 17:53       ` Junio C Hamano
2019-02-06 11:33         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204193823.GA4511@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).