From: Max Kirillov <max@max630.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Max Kirillov <max@max630.net>,
Michael Haggerty <mhagger@alum.mit.edu>,
Git List <git@vger.kernel.org>
Subject: Re: [RFC PATCH] pack-refs: fail on falsely sorted packed-refs
Date: Thu, 31 Jan 2019 10:21:41 +0200 [thread overview]
Message-ID: <20190131082140.GA24787@jessie.local> (raw)
In-Reply-To: <CAPig+cTn2gURyQgWHZQMNf2cZ+zwFhbH1Q4iPmbwuvYjMrPZPg@mail.gmail.com>
On Wed, Jan 30, 2019 at 06:31:34PM -0500, Eric Sunshine wrote:
> On Wed, Jan 30, 2019 at 6:21 PM Max Kirillov <max@max630.net> wrote:
>> + strbuf_addf(err, "broken sorting in packed-refs: '%s' > '%s'",
>> + prev_ref.buf,
>> + iter->refname);
> strbuf_release(&prev_ref) either here or after the "error" label.
Thanks! I seem to forget about it.
> > + git branch b$(printf "%02d" $num) || break
> This should probably be "|| return 1" rather than "|| break" in order
> to fail the test immediately.
I've been looking for the correct way, and have seen the
break somewhere. Now I see the "return 1" is mostly user.
Thanks, will fix.
> Use test_must_fail() rather than '!' when expecting a Git command to fail.
Will fix in both places
next prev parent reply other threads:[~2019-01-31 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 23:13 [RFC PATCH] pack-refs: fail on falsely sorted packed-refs Max Kirillov
2019-01-30 23:31 ` Eric Sunshine
2019-01-31 8:21 ` Max Kirillov [this message]
2019-02-08 21:22 ` [PATCH v2] " Max Kirillov
2019-02-08 21:40 ` Eric Sunshine
2019-02-13 4:24 ` Max Kirillov
[not found] ` <CAMy9T_EX_L80-V4zD626nFCxw6qa90+pZwcbd6wHw9ZHcj2rNA@mail.gmail.com>
2019-02-13 4:23 ` Max Kirillov
2019-02-13 10:08 ` [RFC PATCH] " Ævar Arnfjörð Bjarmason
2019-02-13 10:56 ` SZEDER Gábor
2019-02-23 7:10 ` Max Kirillov
2019-02-14 6:06 ` Jeff King
2019-02-23 7:09 ` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131082140.GA24787@jessie.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).