list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Eric Wong <>
To: Junio C Hamano <>
Cc: "David Turner" <>,
	"SZEDER Gábor" <>,
Subject: [PATCH v2] t1512: test ambiguous cat-file --batch and --batch-output
Date: Wed, 30 Jan 2019 21:33:49 +0000	[thread overview]
Message-ID: <20190130213349.h5xiujbbtw4o3i35@dcvr> (raw)
In-Reply-To: <>

SZEDER Gábor <> wrote:
> The 'git cat-file's error message and hints are translated, so they
> should be checked by 'test_i18ngrep' instead of plain old grep.

Thanks, here's v2 with test_i18ngrep

Subject: [PATCH] t1512: test ambiguous cat-file --batch and --batch-output

Test the new "ambiguous" result from cat-file --batch and
--batch-check.  This is in t1512 instead of t1006 since
we need a repo with ambiguous object_id names.

Signed-off-by: Eric Wong <>
 t/ | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/t/ b/t/
index e4d5b56014..c19fb500cb 100755
--- a/t/
+++ b/t/
@@ -388,4 +388,14 @@ test_expect_success C_LOCALE_OUTPUT 'ambiguous commits are printed by type first
+test_expect_success 'cat-file --batch and --batch-check show ambiguous' '
+	echo "0000 ambiguous" >expect &&
+	echo 0000 | git cat-file --batch-check >actual 2>err &&
+	test_cmp expect actual &&
+	test_i18ngrep hint: err &&
+	echo 0000 | git cat-file --batch >actual 2>err &&
+	test_cmp expect actual &&
+	test_i18ngrep hint: err

      reply	other threads:[~2019-01-30 21:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  3:38 cat-file ambiguity prints "dangling" Eric Wong
2019-01-18  4:46 ` David Turner
2019-01-18 10:45   ` Eric Wong
2019-01-18 16:20     ` David Turner
2019-01-18 22:26       ` [PATCH] t1512: test ambiguous cat-file --batch and --batch-output Eric Wong
2019-01-18 22:29         ` David Turner
2019-01-23 11:11         ` SZEDER Gábor
2019-01-30 21:33           ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130213349.h5xiujbbtw4o3i35@dcvr \ \ \ \ \ \
    --subject='Re: [PATCH v2] t1512: test ambiguous cat-file --batch and --batch-output' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone