git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: David Turner <novalis@novalis.org>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] t1512: test ambiguous cat-file --batch and --batch-output
Date: Fri, 18 Jan 2019 22:26:29 +0000	[thread overview]
Message-ID: <20190118222629.3nvcos24gmi6xe4i@dcvr> (raw)
In-Reply-To: <672a6fb9e480becbfcb5df23ae37193784811b6b.camel@novalis.org>

David Turner <novalis@novalis.org> wrote:
> Let's try this version.

Thanks!

Tested-by: Eric Wong <e@80x24.org>

Not sure if t1512 would be the best place to put the test, but
having a repo with ambiguous data already at hand was easiest.

---------8<-------
Subject: [PATCH] t1512: test ambiguous cat-file --batch and --batch-output

Test the new "ambiguous" result from cat-file --batch and
--batch-check.  This is in t1512 instead of t1006 since
we need a repo with ambiguous object_id names.

Signed-off-by: Eric Wong <e@80x24.org>
---
 t/t1512-rev-parse-disambiguation.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh
index e4d5b56014..b0819630c9 100755
--- a/t/t1512-rev-parse-disambiguation.sh
+++ b/t/t1512-rev-parse-disambiguation.sh
@@ -388,4 +388,14 @@ test_expect_success C_LOCALE_OUTPUT 'ambiguous commits are printed by type first
 	done
 '
 
+test_expect_success 'cat-file --batch and --batch-check show ambiguous' '
+	echo "0000 ambiguous" >expect &&
+	echo 0000 | git cat-file --batch-check >actual 2>err &&
+	test_cmp expect actual &&
+	grep hint: err &&
+	echo 0000 | git cat-file --batch >actual 2>err &&
+	test_cmp expect actual &&
+	grep hint: err
+'
+
 test_done
-- 
EW

  reply	other threads:[~2019-01-18 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  3:38 cat-file ambiguity prints "dangling" Eric Wong
2019-01-18  4:46 ` David Turner
2019-01-18 10:45   ` Eric Wong
2019-01-18 16:20     ` David Turner
2019-01-18 22:26       ` Eric Wong [this message]
2019-01-18 22:29         ` [PATCH] t1512: test ambiguous cat-file --batch and --batch-output David Turner
2019-01-23 11:11         ` SZEDER Gábor
2019-01-30 21:33           ` [PATCH v2] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118222629.3nvcos24gmi6xe4i@dcvr \
    --to=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=novalis@novalis.org \
    --subject='Re: [PATCH] t1512: test ambiguous cat-file --batch and --batch-output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).