From: Jonathan Nieder <jrnieder@gmail.com>
To: Josh Steadmon <steadmon@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Masaya Suzuki <masayasuzuki@google.com>,
git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v2 0/2] Accept error packets in any context
Date: Mon, 14 Jan 2019 17:43:48 -0800 [thread overview]
Message-ID: <20190115014348.GM162110@google.com> (raw)
In-Reply-To: <xmqqef9tfikg.fsf@gitster-ct.c.googlers.com>
Hi,
Junio C Hamano wrote:
> Masaya Suzuki <masayasuzuki@google.com> writes:
>> This makes it possible for servers to send an error message back to clients in
>> an arbitrary situation.
Yay! Yes, this should simplify server implementations and user support.
[...]
> In short, are you shooting js/smart-http-detect-remote-error topic
> down and replacing it with this one?
>
> As that topic is not yet in 'next', I am perfectly fine doing that.
> I just want to make sure that is what you meant, as my reading of
> [4] was a bit fuzzy.
Josh, looking at that branch, I see:
remote-curl: die on server-side errors
Includes a test illustrating error handling in the ref
advertisement. Should that be revived as a standalone patch,
without the remote-curl.c change?
remote-curl: tighten "version 2" check for smart-http
A bug fix. We had an analogous bug in the .googlesource.com
servers and it was problematic when experimenting with
protocol changes using placeholder version numbers YYYYmmdd
(since that starts with a "2").
remote-curl: refactor smart-http discovery
A nice cleanup.
Thanks,
Jonathan
next prev parent reply other threads:[~2019-01-15 1:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <reply-to=20181127045301.103807-1-masayasuzuki@google.com>
2018-12-29 21:19 ` [PATCH v2 0/2] Accept error packets in any context Masaya Suzuki
2018-12-29 21:19 ` [PATCH v2 1/2] Use packet_reader instead of packet_read_line Masaya Suzuki
2019-01-07 19:01 ` Jonathan Tan
2019-01-07 22:33 ` Josh Steadmon
2019-01-08 23:27 ` Masaya Suzuki
2018-12-29 21:19 ` [PATCH v2 2/2] pack-protocol.txt: accept error packets in any context Masaya Suzuki
2019-01-07 19:41 ` Jonathan Tan
2019-01-07 22:53 ` Josh Steadmon
2019-01-03 23:05 ` [PATCH v2 0/2] Accept " Junio C Hamano
2019-01-04 0:20 ` Masaya Suzuki
2019-01-15 1:43 ` Jonathan Nieder [this message]
2019-01-15 1:49 ` Jonathan Nieder
2019-01-15 18:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115014348.GM162110@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=masayasuzuki@google.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).