git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: jonathantanmy@google.com
Cc: gitster@pobox.com, steadmon@google.com, git@vger.kernel.org,
	avarab@gmail.com
Subject: Re: [PATCH] upload-pack: teach deepen-relative in protocol v2
Date: Thu, 10 Jan 2019 14:11:32 -0800	[thread overview]
Message-ID: <20190110221132.52443-1-jonathantanmy@google.com> (raw)
In-Reply-To: <20190110212857.58772-1-jonathantanmy@google.com>

> > This, when applied on top of ecbdaf08991, seems to break t5702.30,
> > at least for me.
> > 
> > Tip of 'pu' in today's push-out will be broken as it has this patch
> > merged.
> > 
> > Can somebody take a look?
> 
> I can reproduce this. I'll investigate this further. In the meantime,
> feel free to remove this from pu.

The test failure is caused by a bug I fixed in [1]. I've verified that
if I apply [1] first, then this, all tests pass. If you do include this
patch in some branch, it should be dependent on [1], but I understand if
you'd like reviewers to look at both this and [1] first.

I thought I tested this without something that fixes the issue fixed by
[1] and it passed, but apparently that's not true.

[1] https://public-inbox.org/git/20190110193645.34080-1-jonathantanmy@google.com/

  reply	other threads:[~2019-01-10 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 21:24 [PATCH] upload-pack: teach deepen-relative in protocol v2 Jonathan Tan
2019-01-09 19:35 ` Josh Steadmon
2019-01-10 18:30   ` Junio C Hamano
2019-01-10 20:43     ` Junio C Hamano
2019-01-10 21:28       ` Jonathan Tan
2019-01-10 22:11         ` Jonathan Tan [this message]
2019-01-10 22:54           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110221132.52443-1-jonathantanmy@google.com \
    --to=jonathantanmy@google.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).