From: "SZEDER Gábor" <szeder.dev@gmail.com> To: Sergey Organov <sorganov@gmail.com> Cc: git@vger.kernel.org, gitster@pobox.com Subject: Re: [PATCH v2 3/4] t3502: validate '-m 1' argument is now accepted for non-merge commits Date: Thu, 3 Jan 2019 18:22:21 +0100 [thread overview] Message-ID: <20190103172221.GB4673@szeder.dev> (raw) In-Reply-To: <ccfe8ae38301b6ee1b0924fbf00eb5d20242ea5d.1544764226.git.sorganov@gmail.com> On Fri, Dec 14, 2018 at 07:53:51AM +0300, Sergey Organov wrote: > Signed-off-by: Sergey Organov <sorganov@gmail.com> > --- > t/t3502-cherry-pick-merge.sh | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/t/t3502-cherry-pick-merge.sh b/t/t3502-cherry-pick-merge.sh > index b160271..3259bd5 100755 > --- a/t/t3502-cherry-pick-merge.sh > +++ b/t/t3502-cherry-pick-merge.sh > @@ -40,12 +40,12 @@ test_expect_success 'cherry-pick -m complains of bogus numbers' ' > test_expect_code 129 git cherry-pick -m 0 b > ' > > -test_expect_success 'cherry-pick a non-merge with -m should fail' ' > +test_expect_success 'cherry-pick explicit first parent of a non-merge' ' > > git reset --hard && > git checkout a^0 && > - test_expect_code 128 git cherry-pick -m 1 b && > - git diff --exit-code a -- > + git cherry-pick -m 1 b && > + git diff --exit-code c -- > > ' > > @@ -84,12 +84,12 @@ test_expect_success 'cherry pick a merge relative to nonexistent parent should f > > ' > > -test_expect_success 'revert a non-merge with -m should fail' ' > +test_expect_success 'revert explicit first parent of a non-merge' ' > > git reset --hard && > git checkout c^0 && > - test_must_fail git revert -m 1 b && > - git diff --exit-code c > + git revert -m 1 b && > + git diff --exit-code a You need disambiguaion here, otherwise this test fails on case-insensitive file systems: ++git diff --exit-code a fatal: ambiguous argument 'a': both revision and filename Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' error: last command exited with $?=128 not ok 8 - revert explicit first parent of a non-merge > > ' > > -- > 2.10.0.1.g57b01a3 >
next prev parent reply other threads:[~2019-01-03 17:22 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 12:42 [PATCH] cherry-pick: do not error on non-merge commits when '-m 1' is specified Sergey Organov 2018-06-21 15:54 ` Junio C Hamano 2018-06-22 9:16 ` Sergey Organov 2018-12-12 5:35 ` Sergey Organov 2018-12-13 4:20 ` Junio C Hamano 2018-12-13 6:35 ` Sergey Organov 2018-12-13 15:35 ` Sergey Organov 2018-12-14 2:36 ` Junio C Hamano 2018-12-14 4:39 ` [PATCH v2 0/4] Allow 'cherry-pick -m 1' for non-merge commits Sergey Organov 2018-12-14 4:53 ` [PATCH v2 2/4] cherry-pick: do not error on non-merge commits when '-m 1' is specified Sergey Organov 2018-12-14 4:53 ` [PATCH v2 1/4] t3510: stop using '-m 1' to force failure mid-sequence of cherry-picks Sergey Organov 2018-12-14 4:53 ` [PATCH v2 3/4] t3502: validate '-m 1' argument is now accepted for non-merge commits Sergey Organov 2019-01-03 17:22 ` SZEDER Gábor [this message] 2019-01-06 14:41 ` Sergey Organov 2018-12-14 4:53 ` [PATCH v2 4/4] t3506: validate '-m 1 -ff' " Sergey Organov 2018-12-25 12:39 ` [PATCH v2 0/4] Allow 'cherry-pick -m 1' " Sergey Organov, Sergey Organov 2018-12-26 22:52 ` Junio C Hamano 2018-12-29 9:10 ` Sergey Organov 2018-12-14 4:39 ` [PATCH v3 " Sergey Organov 2018-12-14 4:53 ` [PATCH v3 1/4] t3510: stop using '-m 1' to force failure mid-sequence of cherry-picks Sergey Organov 2018-12-14 4:53 ` [PATCH v3 2/4] cherry-pick: do not error on non-merge commits when '-m 1' is specified Sergey Organov 2018-12-14 4:53 ` [PATCH v3 3/4] t3502: validate '-m 1' argument is now accepted for non-merge commits Sergey Organov 2018-12-14 4:53 ` [PATCH v3 4/4] t3506: validate '-m 1 -ff' " Sergey Organov 2019-03-19 11:29 ` [PATCH] cherry-pick: do not error on non-merge commits when '-m 1' is specified Sergey Organov 2019-03-20 0:38 ` Junio C Hamano 2019-03-20 5:09 ` Jeff King 2019-03-25 6:43 ` Sergey Organov 2019-03-26 16:32 ` Jeff King 2019-03-26 22:07 ` Elijah Newren 2019-03-26 22:20 ` Jeff King 2019-03-27 0:33 ` Elijah Newren 2019-03-27 13:54 ` Sergey Organov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190103172221.GB4673@szeder.dev \ --to=szeder.dev@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=sorganov@gmail.com \ --subject='Re: [PATCH v2 3/4] t3502: validate '\''-m 1'\'' argument is now accepted for non-merge commits' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).