From: Albert Burt <aburthinds@gmail.com>
To: pclouds@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, stefanbeller@gmail.com,
Albert Burt <aburthinds@gmail.com>
Subject: [PATCH v2] doc: remove unneeded TODO for release_commit_memory
Date: Tue, 1 Jan 2019 15:08:18 -0500 [thread overview]
Message-ID: <20190101200818.81273-1-aburthinds@gmail.com> (raw)
In-Reply-To: <CACsJy8D_gTKWXogPDNW7NQk_a0ChBu28HfGu388hFn3-by_cRw@mail.gmail.com>
Remove TODO that was left in from:
commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
Todo can be removed as:
9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
deletes commit->util.
Signed-off-by: Albert Burt <aburthinds@gmail.com>
---
Thanks for looking at this for me Duy. I updated some of the changes you
suggested.
Let me know if there's anything else that I would need to clean up, or do better.
:)
commit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
c->index = 0;
free_commit_buffer(c);
free_commit_list(c->parents);
- /* TODO: what about commit->util? */
-
c->object.parsed = 0;
}
--
2.17.2 (Apple Git-113)
next prev parent reply other threads:[~2019-01-01 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 23:57 [PATCH] doc: remove unneeded TODO for release_commit_memory Albert Burt
2019-01-01 10:40 ` Duy Nguyen
2019-01-01 20:08 ` Albert Burt [this message]
2019-01-02 11:17 ` [PATCH v2] " Duy Nguyen
2019-01-03 7:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190101200818.81273-1-aburthinds@gmail.com \
--to=aburthinds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).