From: Masaya Suzuki <masayasuzuki@google.com>
To: masayasuzuki@google.com
Cc: git@vger.kernel.org, peff@peff.net, steadmon@google.com
Subject: [PATCH v2 0/2] Accept error packets in any context
Date: Sat, 29 Dec 2018 13:19:13 -0800 [thread overview]
Message-ID: <20181229211915.161686-1-masayasuzuki@google.com> (raw)
In-Reply-To: <reply-to=20181127045301.103807-1-masayasuzuki@google.com>
This makes it possible for servers to send an error message back to clients in
an arbitrary situation.
The first patch was originally sent in [1]. This version includes some fix.
The second patch was originally sent in [2]. Later, this was cherry-picked in
[3]. In the discussion in [3], we agreed that this error packet handling should
be done only against the Git pack protocol handling code. With this agreement,
the patch series sent in [3] is abandoned (according to [4]). This is a patch
series based on that agreement on limiting the error packet handling.
[1]: https://public-inbox.org/git/20181227065210.60817-1-masayasuzuki@google.com/
[2]: https://public-inbox.org/git/20181127045301.103807-1-masayasuzuki@google.com/
[3]: https://public-inbox.org/git/df7d3659ae5f11d163f1e992f3b9403be709ddb7.1544572142.git.steadmon@google.com/
[4]: https://public-inbox.org/git/20181213221826.GE37614@google.com/
Masaya Suzuki (2):
Use packet_reader instead of packet_read_line
pack-protocol.txt: accept error packets in any context
Documentation/technical/pack-protocol.txt | 20 +++----
builtin/archive.c | 19 +++----
builtin/fetch-pack.c | 3 +-
builtin/receive-pack.c | 62 +++++++++++----------
builtin/send-pack.c | 3 +-
connect.c | 3 --
fetch-pack.c | 65 +++++++++++++----------
pkt-line.c | 4 ++
pkt-line.h | 8 ++-
remote-curl.c | 29 ++++++----
send-pack.c | 39 +++++++-------
serve.c | 5 +-
t/t5703-upload-pack-ref-in-want.sh | 4 +-
transport.c | 3 +-
upload-pack.c | 40 +++++++-------
15 files changed, 174 insertions(+), 133 deletions(-)
--
2.20.1.415.g653613c723-goog
next parent reply other threads:[~2018-12-29 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <reply-to=20181127045301.103807-1-masayasuzuki@google.com>
2018-12-29 21:19 ` Masaya Suzuki [this message]
2018-12-29 21:19 ` [PATCH v2 1/2] Use packet_reader instead of packet_read_line Masaya Suzuki
2019-01-07 19:01 ` Jonathan Tan
2019-01-07 22:33 ` Josh Steadmon
2019-01-08 23:27 ` Masaya Suzuki
2018-12-29 21:19 ` [PATCH v2 2/2] pack-protocol.txt: accept error packets in any context Masaya Suzuki
2019-01-07 19:41 ` Jonathan Tan
2019-01-07 22:53 ` Josh Steadmon
2019-01-03 23:05 ` [PATCH v2 0/2] Accept " Junio C Hamano
2019-01-04 0:20 ` Masaya Suzuki
2019-01-15 1:43 ` Jonathan Nieder
2019-01-15 1:49 ` Jonathan Nieder
2019-01-15 18:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229211915.161686-1-masayasuzuki@google.com \
--to=masayasuzuki@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).