From: Jonathan Nieder <jrnieder@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Josh Steadmon <steadmon@google.com>,
Masaya Suzuki <masayasuzuki@google.com>
Subject: Re: [PATCH] config.mak.dev: add -Wformat
Date: Thu, 27 Dec 2018 10:59:00 -0800 [thread overview]
Message-ID: <20181227185900.GE146609@google.com> (raw)
In-Reply-To: <20181012191531.GA22611@hank.intra.tgummerer.com>
+cc: Masaya Suzuki
In October, Thomas Gummerer wrote:
> On 10/12, Jonathan Nieder wrote:
>> Jeff King wrote:
>>> On Fri, Oct 12, 2018 at 07:40:37PM +0100, Thomas Gummerer wrote:
>>>> 801fa63a90 ("config.mak.dev: add -Wformat-security", 2018-09-08) added
>>>> the -Wformat-security to the flags set in config.mak.dev. In the gcc
>>>> man page this is documented as:
>>>>
>>>> If -Wformat is specified, also warn about uses of format
>>>> functions that represent possible security problems. [...]
>>>>
>>>> That commit did however not add the -Wformat flag, and -Wformat is not
>>>> specified anywhere else by default, so the added -Wformat-security had
>>>> no effect. Newer versions of gcc (gcc 8.2.1 in this particular case)
>>>> warn about this and thus compilation fails with this option set.
>> [...]
>>> -Wformat is part of -Wall, which we already turn on by default (even for
>>> non-developer builds).
[...]
>> Thomas, do you use autoconf to generate config.mak.autogen? I'm
>> wondering if that produces a CFLAGS that doesn't include -Wall.
>
> No, this was all my mistake :)
As discussed in [1], autoconf appears to not put -Wall in CFLAGS:
$ make configure
GEN configure
$ ./configure
[...]
config.status: creating config.mak.autogen
config.status: executing config.mak.autogen commands
$ grep CFLAGS config.mak.autogen
CFLAGS = -g -O2
PTHREAD_CFLAGS=-pthread
So this trap for the unwary is still around.
Can we revive this patch? Does it just need a clearer commit message,
or were there other objections?
>>> I'm not opposed to making config.mak.dev a bit more redundant to handle
>>> this case, but we'd probably want to include all of -Wall, since it
>>> contains many other warnings we'd want to make sure are enabled.
>>
>> Do you mean putting -Wall instead of -Wformat?
>>
>> Should we add -Wextra too? From a quick test, it seems to build okay.
>
> We do have that with setting DEVELOPER=extra-all.
Even better. What do you think of making DEVELOPER=YesPlease imply
that?
Thanks,
Jonathan
[1] https://public-inbox.org/git/CAJB1erVmZQd_kLU1fqL7cURrEUz2EJ4Br0kgVQt7T-mk3s95dQ@mail.gmail.com/
next prev parent reply other threads:[~2018-12-27 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 18:40 [PATCH] config.mak.dev: add -Wformat Thomas Gummerer
2018-10-12 18:45 ` Jeff King
2018-10-12 18:54 ` Jonathan Nieder
2018-10-12 19:11 ` Jeff King
2018-10-12 19:15 ` Thomas Gummerer
2018-12-27 18:59 ` Jonathan Nieder [this message]
2019-01-03 16:55 ` Junio C Hamano
2019-01-03 18:54 ` Jonathan Nieder
2019-01-06 18:17 ` Thomas Gummerer
2019-01-07 17:04 ` Junio C Hamano
2019-01-07 21:16 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227185900.GE146609@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).