From: randall.s.becker@rogers.com
To: git@vger.kernel.org
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: [PATCH v1 1/4] transport-helper: use xread instead of read
Date: Wed, 26 Dec 2018 18:05:20 -0500 [thread overview]
Message-ID: <20181226230523.16572-2-randall.s.becker@rogers.com> (raw)
In-Reply-To: <20181226230523.16572-1-randall.s.becker@rogers.com>
From: "Randall S. Becker" <rsbecker@nexbridge.com>
This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than
BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
was the only place outside of wrapper.c where it is used instead of xread.
Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
transport-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport-helper.c b/transport-helper.c
index bf225c698f..a290695a12 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -1225,7 +1225,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
return 0; /* No space for more. */
transfer_debug("%s is readable", t->src_name);
- bytes = read(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
+ bytes = xread(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN &&
errno != EINTR) {
error_errno(_("read(%s) failed"), t->src_name);
--
2.17.0.10.gb132f7033
next prev parent reply other threads:[~2018-12-26 23:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 23:05 [PATCH v1 0/4] HPE NonStop Port Commits randall.s.becker
2018-12-26 23:05 ` randall.s.becker [this message]
2018-12-28 20:10 ` [PATCH v1 1/4] transport-helper: use xread instead of read Junio C Hamano
2018-12-28 20:38 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config randall.s.becker
2018-12-27 17:02 ` Eric Sunshine
2018-12-27 17:44 ` Randall S. Becker
2018-12-28 20:07 ` Junio C Hamano
2018-12-28 20:33 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop randall.s.becker
2018-12-27 12:10 ` Derrick Stolee
2018-12-27 15:55 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop randall.s.becker
2018-12-27 12:12 ` [PATCH v1 0/4] HPE NonStop Port Commits Derrick Stolee
2018-12-27 16:01 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226230523.16572-2-randall.s.becker@rogers.com \
--to=randall.s.becker@rogers.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).